Rollup of 4 pull requests #146304

matthiaskrgr · 2025-09-07T18:02:30Z

Successful merges:

fix: offline rustdoc html missing favicon #146170 (fix: offline rustdoc html missing favicon)
Misc LTO cleanups #146209 (Misc LTO cleanups)
feat(std): emulate flock for solaris via fcntl #146269 (feat(std): emulate flock for solaris via fcntl)
Introduce PlaceContext::may_observe_address. #146297 (Introduce PlaceContext::may_observe_address.)

r? @ghost
@rustbot modify labels: rollup

It is only used within cg_llvm.

It is always false nowadays. ThinLTO summary writing is instead done by llvm_optimize.

Upstream Solaris flock emulation to libstd from cargo. This is borrowed from https://github.com/rust-lang/cargo/blob/3b379fcc541b39321a7758552d37e5e0cc4277b9/src/cargo/util/flock.rs#L502-L536 which was implemented by an Oracle employee. The code has been in cargo since 2022-12. Python's `fcntl.flock` emulates like this as well: https://github.com/python/cpython/blob/c919d02edecfe9d75fe374756fb8aa1db8d95f55/Modules/fcntlmodule.c#L337-L400 We did the same thing in https://github.com/rust-lang/rust/blob/0d0f4eac8b98133e5da6d3604d86a8f3b5a67844/compiler/rustc_data_structures/src/flock/unix.rs#L13-L39

…crum fix: offline rustdoc html missing favicon As discussed in the rust-lang#146149 the doc was missing the favicon icon when build locally and viewed on a browser. I changed the relative path and also now we explicitly copy both SVG and PNG. <img width="1132" height="425" alt="Screenshot 2025-09-03 at 11 57 46 PM" src="https://github.com/user-attachments/assets/062cbb08-04ec-4d88-a43a-710fb6190f82" />

Misc LTO cleanups Follow up to rust-lang#145955. * Remove want_summary argument from `prepare_thin`. Since rust-lang#133250 ThinLTO summary writing is instead done by `llvm_optimize`. * Two minor cleanups

…mulacrum feat(std): emulate flock for solaris via fcntl Upstream Solaris flock emulation to libstd from cargo. This is borrowed from https://github.com/rust-lang/cargo/blob/3b379fcc541b39321a7758552d37e5e0cc4277b9/src/cargo/util/flock.rs#L502-L536 which was implemented by an Oracle employee. The code has been in cargo since 2022-12. Python's `fcntl.flock` emulates like this as well: https://github.com/python/cpython/blob/c919d02edecfe9d75fe374756fb8aa1db8d95f55/Modules/fcntlmodule.c#L337-L400 We did the same thing in https://github.com/rust-lang/rust/blob/0d0f4eac8b98133e5da6d3604d86a8f3b5a67844/compiler/rustc_data_structures/src/flock/unix.rs#L13-L39 However, should we just always falls back to fcntl for all Unix, instead of "unsupported"? try-job: `*-solaris`

…ethlin Introduce PlaceContext::may_observe_address. A small utility method to avoid open-coding the logic in several MIR opts.

matthiaskrgr · 2025-09-07T18:02:43Z

@bors r+ rollup=never p=5

bors · 2025-09-07T18:02:45Z

📌 Commit 36557d1 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-09-07T20:27:46Z

⌛ Testing commit 36557d1 with merge 12eb345...

bors · 2025-09-07T23:35:14Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 12eb345 to master...

rust-timer · 2025-09-07T23:36:24Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#146170	fix: offline rustdoc html missing favicon	`d3b4e2ae025c30dcdb26584c56f25c6e4df4948f` (link)
#146209	Misc LTO cleanups	`d2c3e34400e1daf679e47c8eb0c11d78bf6efd00` (link)
#146269	feat(std): emulate flock for solaris via fcntl	`c9672d1bc94b966bbd08a23f9516e8c3b070b9b2` (link)
#146297	Introduce PlaceContext::may_observe_address.	`771aa30927fcea4398ec3d59260a274c77f7a1f4` (link)

previous master: 23718020b1

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-09-07T23:37:46Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2371802 (parent) -> 12eb345 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 12eb345e5593a10e61b4aef766076c8bd552fea6 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 4827.5s -> 3630.0s (-24.8%)
dist-x86_64-apple: 8473.4s -> 6653.6s (-21.5%)
pr-check-1: 1368.2s -> 1626.5s (18.9%)
dist-aarch64-apple: 6302.3s -> 7268.1s (15.3%)
x86_64-rust-for-linux: 2587.0s -> 2920.8s (12.9%)
x86_64-gnu-llvm-19-1: 3315.0s -> 3715.3s (12.1%)
aarch64-gnu: 6583.1s -> 7336.0s (11.4%)
x86_64-gnu-tools: 3300.2s -> 3663.5s (11.0%)
aarch64-gnu-llvm-19-2: 2245.5s -> 2492.3s (11.0%)
i686-gnu-1: 7348.7s -> 8100.5s (10.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-09-08T00:45:26Z

Finished benchmarking commit (12eb345): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.1%, 0.4%]	8
Regressions ❌ (secondary)	0.4%	[0.1%, 0.9%]	13
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.2%]	1
Improvements ✅ (secondary)	-2.7%	[-2.9%, -2.5%]	6
All ❌✅ (primary)	0.2%	[-0.2%, 0.4%]	9

Max RSS (memory usage)

Results (primary 0.5%, secondary 1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.6%	[1.3%, 1.8%]	2
Regressions ❌ (secondary)	1.7%	[0.7%, 2.3%]	4
Improvements ✅ (primary)	-1.8%	[-1.8%, -1.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[-1.8%, 1.8%]	3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 467.642s -> 468.162s (0.11%)
Artifact size: 387.46 MiB -> 387.46 MiB (-0.00%)

panstromek · 2025-09-15T16:06:51Z

perf triage:

Regression looks to be caused by #146297, continuing the discussion there.

@rustbot label: +perf-regression-triaged

kumarUjjawal and others added 10 commits September 4, 2025 00:03

fix: offline rustdoc html missing favicon

f3650b8

Remove thin_link_data method from ThinBufferMethods

e3d0b7d

It is only used within cg_llvm.

Remove want_summary argument from prepare_thin

f2933b3

It is always false nowadays. ThinLTO summary writing is instead done by llvm_optimize.

Move timers into execute_*_work_item

3a1ae06

Introduce PlaceContext::may_observe_address.

4e7a068

Rollup merge of rust-lang#146209 - bjorn3:lto_refactors5, r=dianqk

92bad93

Misc LTO cleanups Follow up to rust-lang#145955. * Remove want_summary argument from `prepare_thin`. Since rust-lang#133250 ThinLTO summary writing is instead done by `llvm_optimize`. * Two minor cleanups

Rollup merge of rust-lang#146297 - cjgillot:may-observe-address, r=sa…

36557d1

…ethlin Introduce PlaceContext::may_observe_address. A small utility method to avoid open-coding the logic in several MIR opts.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 7, 2025

bors merged commit 12eb345 into rust-lang:master Sep 7, 2025
11 checks passed

rustbot added this to the 1.91.0 milestone Sep 7, 2025

bors mentioned this pull request Sep 8, 2025

[TOY] Extend GVN to perform local value numbering. #143333

Draft

rustbot added the perf-regression Performance regression. label Sep 8, 2025

panstromek mentioned this pull request Sep 15, 2025

Introduce PlaceContext::may_observe_address. #146297

Merged

rustbot added the perf-regression-triaged The performance regression has been triaged. label Sep 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 4 pull requests #146304

Rollup of 4 pull requests #146304

matthiaskrgr commented Sep 7, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Sep 7, 2025

Uh oh!

bors commented Sep 7, 2025

Uh oh!

bors commented Sep 7, 2025

Uh oh!

bors commented Sep 7, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 7, 2025

Uh oh!

github-actions bot commented Sep 7, 2025

Uh oh!

rust-timer commented Sep 8, 2025

Uh oh!

panstromek commented Sep 15, 2025

Uh oh!

Uh oh!

Rollup of 4 pull requests #146304

Rollup of 4 pull requests #146304

Conversation

matthiaskrgr commented Sep 7, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Sep 7, 2025

Uh oh!

bors commented Sep 7, 2025

Uh oh!

bors commented Sep 7, 2025

Uh oh!

bors commented Sep 7, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 7, 2025

Uh oh!

github-actions bot commented Sep 7, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Sep 8, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

panstromek commented Sep 15, 2025

Uh oh!

Uh oh!

matthiaskrgr commented Sep 7, 2025 •

edited by rustbot

Loading