Skip to content

cg_llvm: Use LLVM-C bindings for LLVMSetTailCallKind, LLVMGetTypeKind #145420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Zalathar
Copy link
Contributor

This PR replaces two existing LLVMRust bindings with equivalent calls to the LLVM-C API.

For LLVMGetTypeKind, we avoid the UB hazard by declaring the foreign function to return RawEnum<TypeKind> (which is a wrapper around u32), and then perform checked conversion from u32 to TypeKind.

@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 15, 2025
@Zalathar
Copy link
Contributor Author

Zalathar commented Aug 15, 2025

cc @WaffleLapkin in case there was some specific reason for the custom LLVMRustSetTailCallKind binding that I didn't think of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants