bootstrap: Reduce dependencies #145413
Open
bootstrap: Reduce dependencies #145413
+24
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @clubby789 rustbot has assigned @clubby789. Use |
rustbot
added
S-waiting-on-review
This comment was marked as outdated.
This comment was marked as outdated.
joshtriplett
force-pushed
the
bootstrap-reduce-deps
branch
from
73fec3a to
669e750
Compare
In the process, fix a race condition, by never truncating or writing to the file unless we currently hold the lock.
Extracting the Rust tarballs doesn't require this.
joshtriplett
force-pushed
the
bootstrap-reduce-deps
branch
from
669e750 to
56b33cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate the
fd-lockdependency by using the new native locking in std.Eliminate the
xattrdependency by turning off a feature flag intar, sincethe tarballs that we extract with bootstrap don't need it.