Split codegen backend check step into two and don't run it with x check compiler
#145340
+91
−170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
S-waiting-on-review
jieyouxu
approved these changes
Aug 13, 2025
| impl Step for GccCodegenBackend { | ||
| type Output = (); | ||
|
|
||
| const ONLY_HOSTS: bool = true; |
There was a problem hiding this comment.
Remark: will conflict with #145324
rustbot
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #145131) made this pull request unmergeable. Please resolve the merge conflicts. |
Kobzol
force-pushed
the
bootstrap-codegen-backend-check-split
branch
from
819462e to
2a2903c
Compare
|
Rebased. @bors r=jieyouxu |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 15, 2025
Rollup of 11 pull requests Successful merges: - #144210 (std: thread: Return error if setting thread stack size fails) - #145310 (Reduce usage of `compiler_for` in bootstrap) - #145311 (ci: clean windows disk space in background) - #145340 (Split codegen backend check step into two and don't run it with `x check compiler`) - #145408 (Deduplicate -L search paths) - #145412 (Windows: Replace `GetThreadId`+`GetCurrentThread` with `GetCurrentThreadId`) - #145413 (bootstrap: Reduce dependencies) - #145426 (Fix typos in bootstrap.example.toml) - #145430 (Fix wrong spans with external macros in the `dropping_copy_types` lint) - #145431 (Enhance UI test output handling for runtime errors) - #145448 (Autolabel `src/tools/{rustfmt,rust-analyzer}` changes with `T-{rustfmt,rust-analyzer}`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Aug 15, 2025
Rollup merge of #145340 - Kobzol:bootstrap-codegen-backend-check-split, r=jieyouxu Split codegen backend check step into two and don't run it with `x check compiler` This reduces the amount of work that is done during `x check compiler`. We still check both backends during `x check` by defaut, even if they are not in `rust.codegen-backends`, as just checking them shouldn't require expensive preparations, like building GCC. r? `@jieyouxu`
|
Hmm, I seem to have removed all Clippy snapshot tests during the latest rebase or something, lol. I'll readd them in the next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the amount of work that is done during
x check compiler. We still check both backends duringx checkby defaut, even if they are not inrust.codegen-backends, as just checking them shouldn't require expensive preparations, like building GCC.r? @jieyouxu