Extract ImplOfTrait in AST/HIR #144386
Open
Extract ImplOfTrait in AST/HIR #144386
+580
−518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
rustbot
added
A-attributes
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt HIR ty lowering was modified cc @fmease Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
This comment has been minimized.
This comment has been minimized.
I don't think that's true fwiw. |
This comment has been minimized.
This comment has been minimized.
This means this PR change the code in |
|
@rustbot author |
rustbot
removed
the
S-waiting-on-review
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
xizheyin
reviewed
Jul 24, 2025
fbstj
reviewed
Jul 24, 2025
This comment has been minimized.
This comment has been minimized.
fmease
reviewed
Jul 24, 2025
| } | ||
|
|
||
| #[derive(Clone, Encodable, Decodable, Debug)] | ||
| pub struct ImplOfTrait { |
There was a problem hiding this comment.
I find ImplOfTrait (or TraitImpl) to be very misleading since it doesn't represent a full trait impl.
First I thought maybe TraitImplHeader (impl header is pre-existing jargon) but for that it lacks the self_ty and the generics.
I'm currently leaning towards ImplTraitRef (impl trait ref is pre-existing jargon for the trait ref in an impl). It's not 100% technically correct since the "modifiers" belong to the impl not to the ref, so 🤔
There was a problem hiding this comment.
I find
ImplOfTrait(orTraitImpl) to be very misleading since it doesn't represent a full trait impl.
Yeah I see your point, though I feel like this wont cause much confusion in practice.
The first thing I had was
enum ImplKind {
Inherent(/* self ty */ Ty)
Trait(ImplOfTrait)
}...with self_ty repeated in the two variants. But then I decided it's ultimately simpler to not duplicate anything, and then I decided that ImplKind can just be an Option.
Another option could be to have
enum ImplKind {
Inherent,
Trait { defaultness, constness, .... } // inline the things
}...but a problem there is that I can't insert a box. I'm hoping that the box move is a perf win because I removed a box from ItemKind::Impl(noboxhere). Also I like the convenience of being able to bind the of_trait object, but that's minor.
I don't think "trait ref" works because I think that term specifically means the part of the code that references a trait.
TraitImplHeader seems alright to me. (Or maybe ImplTraitHeader? But that kinda sounds like -> impl _.)
|
I'll perf this due to the added indirection for impl "modifiers" + extra alloc + size changes. @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Jul 24, 2025
Extract ImplOfTrait in AST/HIR
rustbot
added
the
S-waiting-on-perf
This comment has been minimized.
This comment has been minimized.
fmease
added
the
needs-fcp
fmease
added
T-lang
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
I'll pause on fixing tests for now. |
|
☔ The latest upstream changes (presumably #144398) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors try parent=last |
rust-bors bot
added a commit
that referenced
this pull request
Jul 24, 2025
Extract ImplOfTrait in AST/HIR
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (e071e73): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.6%, secondary 0.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -3.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 468.258s -> 467.481s (-0.17%) |
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 26, 2025
…only, r=compiler-errors Limit defaultness query to impl of trait I separated this out from rust-lang#144386.
|
🎉 Experiment
|
craterbot
added
S-waiting-on-review
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jul 28, 2025
…ompiler-errors Limit defaultness query to impl of trait I separated this out from rust-lang/rust#144386.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fields of
Implare only applicable when it's a trait impl. This moves those fields into a new struct that is only present for trait impls.I also considered the name
ImplTraitorTraitImplbut I thought that might be more easily confused with-> impl _. The variable nameof_traitworks nice since it is unique and you can infer what it means.