implement Sum and Product for Saturating(u*) #144275
Open
+96
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
tgross35
reviewed
Jul 22, 2025
|
Could you add some tests to library/coretests/tests/iter/traits/accum.rs verifying the behavior? @rustbot label +I-libs-api-nominated |
rustbot
added
the
I-libs-api-nominated
|
FCP since this is insta-stable. @rfcbot merge |
This comment was marked as outdated.
This comment was marked as outdated.
rfcbot
added
proposed-final-comment-period
Amanieu
removed
the
I-libs-api-nominated
the8472
reviewed
Jul 22, 2025
Amanieu
added
T-libs-api
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
rfcbot
removed
proposed-final-comment-period
This comment was marked as outdated.
This comment was marked as outdated.
|
Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACP: rust-lang/libs-team#604
@rustbot label +needs-fcp