-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Only run asm tests if they match the current codegen backend #144249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Some changes occurred in src/tools/compiletest cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
3132461
to
a6509f8
Compare
There are changes to the cc @jieyouxu |
a6509f8
to
660aad9
Compare
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
Since this is mostly a compiletest thing, I'll delegate to jieyouxu: Maybe there's a better way to detect the r? @jieyouxu |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests all are not LLVM specific. They test asm!()
(which is backend agnostic, just target dependent), not --emit asm
(which will produce different output depending on the backend).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah interesting! So I should move all asm!()
tests into a tests/ui/asm
folder which would be backend agnostic.
One question: should I move all tests containing asm!
calls or is there another heuristic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests/ui/asm shouldn't contain any backend specific tests. Those are in tests/assembly and tests/codegen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, sorry I misunderstood. Then updating the other testsuites.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^
660aad9
to
63aa472
Compare
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred in src/tools/opt-dist cc @Kobzol Some changes occurred in compiler/rustc_codegen_gcc |
Applied suggestions. |
This comment has been minimized.
This comment has been minimized.
… the current codegen backend
63aa472
to
20af4f1
Compare
Added the missing bits so I think I didn't forget anything this time. |
Follow-up of #144125.
This PR changes
compiletest
so thatasm
tests are only run if they match the current codegen backend. To better reflect it, I renamed thetests/ui/asm
folder intotests/ui/asm-llvm
. Like that, we can add new asm tests for other backends if we want without needing to add extra code tocompiletest
.Next step will be to use the new code annotations added in #144125 to ignore ui tests failing in cg_gcc until it's fixed on our side.
cc @antoyo @oli-obk
r? @Kobzol