Reword mismatched-lifetime-syntaxes text based on feedback #143914

shepmaster · 2025-07-14T02:47:49Z

Key changes include:

Removal of the word "syntax" from the lint message. More accurately, it could have been something like "syntax group" or "syntax category", but avoiding it completely is easier.
The primary lint message now reflects exactly which mismatch is occurring, instead of trying to be general. A new help line is general across the mismatch kinds.
Suggestions have been reduced to be more minimal, no longer also changing non-idiomatic but unrelated aspects.
Suggestion text no longer mentions changes when those changes don't occur in that specific suggestion.

jieyouxu · 2025-07-14T09:50:48Z

I'll look at this on Wednesday.

Key changes include: - Removal of the word "syntax" from the lint message. More accurately, it could have been something like "syntax group" or "syntax category", but avoiding it completely is easier. - The primary lint message now reflects exactly which mismatch is occurring, instead of trying to be general. A new `help` line is general across the mismatch kinds. - Suggestions have been reduced to be more minimal, no longer also changing non-idiomatic but unrelated aspects. - Suggestion text no longer mentions changes when those changes don't occur in that specific suggestion.

jieyouxu

Thanks for the follow-up! At least for me, I find this revised wording and diagnostics much clearer in terms of "why is this a problem" and "what am I expected to do".

jieyouxu · 2025-07-16T12:39:35Z

tests/ui/lifetimes/mismatched-lifetime-syntaxes.stderr

+error: hiding or eliding a lifetime that's named elsewhere is confusing
+  --> $DIR/mismatched-lifetime-syntaxes.rs:232:53
+   |
+LL |     fn all_three_categories<'a>(v: ContainsLifetime<'a>) -> (&u8, ContainsLifetime) {
+   |                                                     ^^       ---  ---------------- the same lifetime is hidden here
+   |                                                     |        |
+   |                                                     |        the same lifetime is elided here
+   |                                                     the lifetime is named here
+   |
+   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
+help: consistently use `'a`
+   |
+LL |     fn all_three_categories<'a>(v: ContainsLifetime<'a>) -> (&'a u8, ContainsLifetime<'a>) {
+   |                                                               ++                     ++++


Remark: this is very nice :)

rustbot · 2025-07-16T16:23:30Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

shepmaster · 2025-07-16T16:33:29Z

/cc @traviscross. Since you effectively proposed the wording in this PR, I'm going to assume that you also approve of it. We've got an approval from the compiler team, so I'm inclined to merge this sooner rather than later so it can get beta-nominated faster.

jieyouxu · 2025-07-16T16:39:03Z

r? @traviscross (for wording)

shepmaster · 2025-07-16T16:39:13Z

I'm also going to jump the gun here and nominate for this to be backported to beta. The current wording has been reported to be suboptimal, so hopefully we can skip having a 6-week period of confusion. If not, it wouldn't be the end of the world.

traviscross

Thanks @shepmaster for making these updates.

jieyouxu · 2025-07-16T16:41:13Z

Oh I forgot to say, impl looks good, so r=me on the impl side.

shepmaster · 2025-07-16T16:42:20Z

@bors r=traviscross,jieyouxu rollup

bors · 2025-07-16T16:42:22Z

📌 Commit 5530744 has been approved by traviscross,jieyouxu

It is now in the queue for this repository.

…taxes-rewording, r=traviscross,jieyouxu Reword mismatched-lifetime-syntaxes text based on feedback Key changes include: - Removal of the word "syntax" from the lint message. More accurately, it could have been something like "syntax group" or "syntax category", but avoiding it completely is easier. - The primary lint message now reflects exactly which mismatch is occurring, instead of trying to be general. A new `help` line is general across the mismatch kinds. - Suggestions have been reduced to be more minimal, no longer also changing non-idiomatic but unrelated aspects. - Suggestion text no longer mentions changes when those changes don't occur in that specific suggestion. r? `@jieyouxu`

…taxes-rewording, r=traviscross,jieyouxu Reword mismatched-lifetime-syntaxes text based on feedback Key changes include: - Removal of the word "syntax" from the lint message. More accurately, it could have been something like "syntax group" or "syntax category", but avoiding it completely is easier. - The primary lint message now reflects exactly which mismatch is occurring, instead of trying to be general. A new `help` line is general across the mismatch kinds. - Suggestions have been reduced to be more minimal, no longer also changing non-idiomatic but unrelated aspects. - Suggestion text no longer mentions changes when those changes don't occur in that specific suggestion. r? ``@jieyouxu``

…taxes-rewording, r=traviscross,jieyouxu Reword mismatched-lifetime-syntaxes text based on feedback Key changes include: - Removal of the word "syntax" from the lint message. More accurately, it could have been something like "syntax group" or "syntax category", but avoiding it completely is easier. - The primary lint message now reflects exactly which mismatch is occurring, instead of trying to be general. A new `help` line is general across the mismatch kinds. - Suggestions have been reduced to be more minimal, no longer also changing non-idiomatic but unrelated aspects. - Suggestion text no longer mentions changes when those changes don't occur in that specific suggestion. r? ```@jieyouxu```

shepmaster added the L-mismatched_lifetime_syntaxes Lint: mismatched_lifetime_syntaxes label Jul 14, 2025

rustbot assigned jieyouxu Jul 14, 2025

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 14, 2025

This comment has been minimized.

Sign in to view

shepmaster force-pushed the mismatched-lifetime-syntaxes-rewording branch from 677cf7b to 14baad4 Compare July 14, 2025 13:34

shepmaster force-pushed the mismatched-lifetime-syntaxes-rewording branch from 14baad4 to 5530744 Compare July 14, 2025 15:30

jieyouxu approved these changes Jul 16, 2025

View reviewed changes

shepmaster marked this pull request as ready for review July 16, 2025 16:23

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 16, 2025

shepmaster added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 16, 2025

rustbot assigned traviscross and unassigned jieyouxu Jul 16, 2025

traviscross approved these changes Jul 16, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2025

This was referenced Jul 16, 2025

Suggestion follow-up for mismatched-lifetime-syntaxes lint #142087

Closed

Restore mismatched_lifetime_syntaxes wording about "elided lifetime has a name"? #141752

Closed

matthiaskrgr mentioned this pull request Jul 16, 2025

Rollup of 12 pull requests #144035

Closed

matthiaskrgr mentioned this pull request Jul 16, 2025

Rollup of 12 pull requests #144036

Closed

matthiaskrgr mentioned this pull request Jul 16, 2025

Rollup of 11 pull requests #144038

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reword mismatched-lifetime-syntaxes text based on feedback #143914

Reword mismatched-lifetime-syntaxes text based on feedback #143914

shepmaster commented Jul 14, 2025

Uh oh!

This comment has been minimized.

jieyouxu commented Jul 14, 2025

Uh oh!

jieyouxu left a comment

Uh oh!

jieyouxu Jul 16, 2025

Uh oh!

rustbot commented Jul 16, 2025

Uh oh!

shepmaster commented Jul 16, 2025

Uh oh!

jieyouxu commented Jul 16, 2025

Uh oh!

shepmaster commented Jul 16, 2025

Uh oh!

traviscross left a comment

Uh oh!

jieyouxu commented Jul 16, 2025

Uh oh!

shepmaster commented Jul 16, 2025

Uh oh!

bors commented Jul 16, 2025

Uh oh!

Uh oh!

Reword mismatched-lifetime-syntaxes text based on feedback #143914

Are you sure you want to change the base?

Reword mismatched-lifetime-syntaxes text based on feedback #143914

Conversation

shepmaster commented Jul 14, 2025

Uh oh!

This comment has been minimized.

jieyouxu commented Jul 14, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

rustbot commented Jul 16, 2025

Uh oh!

shepmaster commented Jul 16, 2025

Uh oh!

jieyouxu commented Jul 16, 2025

Uh oh!

shepmaster commented Jul 16, 2025

Uh oh!

traviscross left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Jul 16, 2025

Uh oh!

shepmaster commented Jul 16, 2025

Uh oh!

bors commented Jul 16, 2025

Uh oh!

Uh oh!