-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Ban projecting into SIMD types [MCP838] #143833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Since you previously commented on 138036, how about |
The Miri subtree was changed cc @rust-lang/miri Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred in compiler/rustc_codegen_ssa |
@bors r+ rollup |
…-errors Ban projecting into SIMD types [MCP838] Closes rust-lang/compiler-team#838 The actual compiler change here is tiny; there's just a bazillion tests to update. Since I'm sure I've missed some, for now r? ghost
…-errors Ban projecting into SIMD types [MCP838] Closes rust-lang/compiler-team#838 The actual compiler change here is tiny; there's just a bazillion tests to update. Since I'm sure I've missed some, for now r? ghost
…idation, r=RalfJung Give a message with a span on MIR validation error It was handy to get a source+line link for rust-lang#143833, even if it's just to the function and not necessarily to the statement. r? mir
…idation, r=RalfJung Give a message with a span on MIR validation error It was handy to get a source+line link for rust-lang#143833, even if it's just to the function and not necessarily to the statement. r? mir
And checking the two jobs that have failed in bors without being caught by ci: |
Ban projecting into SIMD types [MCP838] Closes rust-lang/compiler-team#838 The actual compiler change here is tiny; there's just a bazillion tests to update. ~~Since I'm sure I've missed some, for now~~ ~~r ghost~~ try-job: test-various try-job: x86_64-gnu-nopt
☀️ Try build successful - checks-actions |
Both jobs that have failed in bors on this in the past just succeeded in that last try run, so let's give it another shot 🤞 |
…r=RalfJung Give a message with a span on MIR validation error It was handy to get a source+line link for rust-lang/rust#143833, even if it's just to the function and not necessarily to the statement. r? mir
…r=RalfJung Give a message with a span on MIR validation error It was handy to get a source+line link for rust-lang/rust#143833, even if it's just to the function and not necessarily to the statement. r? mir
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 460259d (parent) -> e05ab47 (this PR) Test differencesShow 7 test diffsStage 1
Stage 2
Additionally, 3 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e05ab47e6c418fb2b9faa2eae9a7e70c65c98eaa --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
I'm glad it worked, but it figures that as soon as I give up on rollups I get it right 🤦 |
Finished benchmarking commit (e05ab47): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -3.2%, secondary -4.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 466.025s -> 466.006s (-0.00%) |
Closes rust-lang/compiler-team#838
The actual compiler change here is tiny; there's just a bazillion tests to update.
Since I'm sure I've missed some, for nowr ghosttry-job: test-various
try-job: x86_64-gnu-nopt