Skip to content

Ban projecting into SIMD types [MCP838] #143833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 21, 2025
Merged

Conversation

scottmcm
Copy link
Member

@scottmcm scottmcm commented Jul 12, 2025

Closes rust-lang/compiler-team#838

The actual compiler change here is tiny; there's just a bazillion tests to update.

Since I'm sure I've missed some, for now
r ghost

try-job: test-various
try-job: x86_64-gnu-nopt

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 12, 2025
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@scottmcm
Copy link
Member Author

Since you previously commented on 138036, how about
r? @compiler-errors

@scottmcm scottmcm marked this pull request as ready for review July 13, 2025 19:47
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 13, 2025

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 16, 2025

📌 Commit fa7734a has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2025
fmease added a commit to fmease/rust that referenced this pull request Jul 17, 2025
…-errors

Ban projecting into SIMD types [MCP838]

Closes rust-lang/compiler-team#838

The actual compiler change here is tiny; there's just a bazillion tests to update.

Since I'm sure I've missed some, for now
r? ghost
fmease added a commit to fmease/rust that referenced this pull request Jul 17, 2025
…-errors

Ban projecting into SIMD types [MCP838]

Closes rust-lang/compiler-team#838

The actual compiler change here is tiny; there's just a bazillion tests to update.

Since I'm sure I've missed some, for now
r? ghost
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 20, 2025
…idation, r=RalfJung

Give a message with a span on MIR validation error

It was handy to get a source+line link for rust-lang#143833, even if it's just to the function and not necessarily to the statement.

r? mir
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 20, 2025
…idation, r=RalfJung

Give a message with a span on MIR validation error

It was handy to get a source+line link for rust-lang#143833, even if it's just to the function and not necessarily to the statement.

r? mir
rust-timer added a commit that referenced this pull request Jul 20, 2025
Rollup merge of #144190 - scottmcm:spanned-errors-in-mir-validation, r=RalfJung

Give a message with a span on MIR validation error

It was handy to get a source+line link for #143833, even if it's just to the function and not necessarily to the statement.

r? mir
@scottmcm
Copy link
Member Author

@bors r-
Needs an update since #144190 merged first

@scottmcm
Copy link
Member Author

And checking the two jobs that have failed in bors without being caught by ci:
@bors try

@bors
Copy link
Collaborator

bors commented Jul 20, 2025

⌛ Trying commit 41ce1ed with merge 4dc4ab1...

bors added a commit that referenced this pull request Jul 20, 2025
Ban projecting into SIMD types [MCP838]

Closes rust-lang/compiler-team#838

The actual compiler change here is tiny; there's just a bazillion tests to update.

~~Since I'm sure I've missed some, for now~~
~~r ghost~~

try-job: test-various
try-job: x86_64-gnu-nopt
@bors
Copy link
Collaborator

bors commented Jul 20, 2025

☀️ Try build successful - checks-actions
Build commit: 4dc4ab1 (4dc4ab197770cfd2da11fb83b224df924e7e594f)

@scottmcm
Copy link
Member Author

Both jobs that have failed in bors on this in the past just succeeded in that last try run, so let's give it another shot 🤞
@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Jul 20, 2025

📌 Commit 41ce1ed has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 20, 2025
@bors
Copy link
Collaborator

bors commented Jul 21, 2025

⌛ Testing commit 41ce1ed with merge e05ab47...

github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jul 21, 2025
…r=RalfJung

Give a message with a span on MIR validation error

It was handy to get a source+line link for rust-lang/rust#143833, even if it's just to the function and not necessarily to the statement.

r? mir
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jul 21, 2025
…r=RalfJung

Give a message with a span on MIR validation error

It was handy to get a source+line link for rust-lang/rust#143833, even if it's just to the function and not necessarily to the statement.

r? mir
@bors
Copy link
Collaborator

bors commented Jul 21, 2025

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing e05ab47 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 21, 2025
@bors bors merged commit e05ab47 into rust-lang:master Jul 21, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 21, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 460259d (parent) -> e05ab47 (this PR)

Test differences

Show 7 test diffs

Stage 1

  • [codegen] tests/codegen/simd/project-to-simd-array-field.rs: pass -> [missing] (J0)
  • [ui] tests/ui/mir/validate/project-into-simd.rs: [missing] -> pass (J0)

Stage 2

  • [codegen] tests/codegen/simd/project-to-simd-array-field.rs: pass -> [missing] (J1)
  • [ui] tests/ui/mir/validate/project-into-simd.rs: [missing] -> pass (J2)

Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.

Job group index

  • J0: x86_64-gnu-llvm-19-3, x86_64-gnu-llvm-20-3
  • J1: aarch64-apple, aarch64-gnu, aarch64-msvc-1, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-1, x86_64-gnu, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-20-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
  • J2: aarch64-apple, aarch64-gnu, aarch64-msvc-1, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-2, x86_64-gnu, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-20-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e05ab47e6c418fb2b9faa2eae9a7e70c65c98eaa --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 7318.3s -> 5588.6s (-23.6%)
  2. aarch64-apple: 4203.8s -> 5193.2s (23.5%)
  3. x86_64-apple-2: 5373.1s -> 4143.1s (-22.9%)
  4. test-various: 4522.2s -> 5035.3s (11.3%)
  5. dist-aarch64-apple: 5238.1s -> 5752.6s (9.8%)
  6. aarch64-msvc-1: 6968.7s -> 7642.9s (9.7%)
  7. dist-ohos-armv7: 3763.3s -> 4089.4s (8.7%)
  8. x86_64-msvc-1: 7906.6s -> 8586.6s (8.6%)
  9. x86_64-gnu-debug: 6468.4s -> 5934.8s (-8.2%)
  10. armhf-gnu: 4885.6s -> 5273.4s (7.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@scottmcm
Copy link
Member Author

I'm glad it worked, but it figures that as soon as I give up on rollups I get it right 🤦

@scottmcm scottmcm deleted the final-mcp-838 branch July 21, 2025 05:49
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e05ab47): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -3.2%, secondary -4.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.2% [-5.4%, -1.0%] 2
Improvements ✅
(secondary)
-4.1% [-6.6%, -2.3%] 6
All ❌✅ (primary) -3.2% [-5.4%, -1.0%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 466.025s -> 466.006s (-0.00%)
Artifact size: 374.56 MiB -> 374.60 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ban projecting into repr(simd) types
7 participants