Added error for invalid char cast #143678
Open
+222
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
hkBst
suggested changes
Jul 9, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Kivooeo
force-pushed
the
char-overflow
branch
2 times, most recently
from
84cd0b4 to
1260317
Compare
hkBst
suggested changes
Jul 9, 2025
|
I had a few more suggestions, but this is nearing completion: good work! |
fmease
reviewed
Jul 9, 2025
Kivooeo
force-pushed
the
char-overflow
branch
2 times, most recently
from
9cc1707 to
7b17511
Compare
hkBst
reviewed
Jul 10, 2025
hkBst
reviewed
Jul 10, 2025
hkBst
reviewed
Jul 10, 2025
hkBst
approved these changes
Jul 10, 2025
|
@fmease your turn ;P |
SparrowLii
approved these changes
Jul 16, 2025
|
@bors r+ |
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 16, 2025
Added error for invalid char cast fixes rust-lang#143597 not really sure if I did it right, but according to cast-char test -- it is right, also this code gave me false positive result ``` for _ in 0..(256 as u8) {} ``` so this is why I added this check `if lit_val <= 0xFF` Also I believe that error message could be improved, but I'm not sure how exactly cc `@hkBst` r? compiler
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 16, 2025
Added error for invalid char cast fixes rust-lang#143597 not really sure if I did it right, but according to cast-char test -- it is right, also this code gave me false positive result ``` for _ in 0..(256 as u8) {} ``` so this is why I added this check `if lit_val <= 0xFF` Also I believe that error message could be improved, but I'm not sure how exactly cc ``@hkBst`` r? compiler
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 16, 2025
Added error for invalid char cast fixes rust-lang#143597 not really sure if I did it right, but according to cast-char test -- it is right, also this code gave me false positive result ``` for _ in 0..(256 as u8) {} ``` so this is why I added this check `if lit_val <= 0xFF` Also I believe that error message could be improved, but I'm not sure how exactly cc ```@hkBst``` r? compiler
bors
added a commit
that referenced
this pull request
Jul 16, 2025
Rollup of 11 pull requests Successful merges: - #143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call) - #143678 (Added error for invalid char cast) - #143793 (Opaque type collection: Guard against endlessly recursing free alias types) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143829 (Trim `BorrowedCursor` API) - #143856 (Linting public reexport of private dependencies) - #143891 (Port `#[coverage]` to the new attribute system) - #143914 (Reword mismatched-lifetime-syntaxes text based on feedback) - #143922 (Improve path segment joining) - #143926 (Remove deprecated fields in bootstrap) - #143975 (type_id_eq: check that the hash fully matches the type) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #143597
not really sure if I did it right, but according to cast-char test -- it is right, also this code gave me false positive result
so this is why I added this check
if lit_val <= 0xFFAlso I believe that error message could be improved, but I'm not sure how exactly
cc @hkBst
r? compiler