std: sys: net: uefi: tcp4: Add timeout support #143568
Conversation
Ayush1325
commented
Jul 7, 2025
Ayush1325
commented
- Implement timeout support for read, write and connect.
- A software implementation using Instant.
- Implement timeout support for read, write and connect. - A software implementation using Instant. Signed-off-by: Ayush Singh <[email protected]>
rustbot
added
S-waiting-on-review
|
Cc @nicholasbishop for UEFI |
| @@ -167,6 +168,31 @@ impl Tcp4 { | |||
| } | |||
| } | |||
|
|
|||
| unsafe fn wait_or_cancel( | |||
There was a problem hiding this comment.
Here and on cancel, a docstring that includes the # Safety requirements would be good to add.
|
|
||
| unsafe fn cancel(&self, event: r_efi::efi::Event) -> io::Result<()> { | ||
| let protocol = self.protocol.as_ptr(); | ||
| let mut completion_token = tcp4::CompletionToken { event, status: Status::SUCCESS }; |
There was a problem hiding this comment.
From https://uefi.org/specs/UEFI/2.11/28_Network_Protocols_TCP_IP_and_Configuration.html#efi-ip4-protocol-cancel: "Pointer to a token that has been issued by EFI_IP4_PROTOCOL.Transmit() or EFI_IP4_PROTOCOL.Receive()". I read that to mean that the completion_token arg should be a pointer to the one created in the read and write methods above, not a new one.
(Also, if read literally it would seem like that means cancel can only be used for canceling receive/transmit, not connect. However, the edk2 implementation at least does not seem to have that restriction.)
