slice: Mark rotate_left
, rotate_right
unstably const
#143554
Open
+21
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
const_slice_rotate
feature<[T]>::rotate_left
and<[T]>::rotate_right
as const unstableThe internal rotate functions use
<*mut T>::replace
andptr::swap_nonoverlapping
which were const-stabilized in 1.88.Two changes were needed in the
rotate.rs
module to make these functions const:cmp::min
was replaced with a local function implementation ofOrd::min
.for start in 1..gcd
loop was changed to a while loop with an increment variable.This needs libs-api approval and cc-ing const-eval.
Tracking issue will be made upon acceptance.