-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Fix rustdoc not correctly showing attributes on re-exports #143083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
c26ae66
to
6a35690
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe could use a comment on the test, but I think its simple enough to be self-explanatory.
I've looked through AttributeKind
and there's nothing there that seems like it should be hidden only when an item is inlined, with the possible exception of doc(inline)
itself, although the code suggests that the doc attribute isn't using the new attribute parsing system yet.
6a35690
to
f04183b
Compare
Signed-off-by: Jonathan Brouwer <[email protected]>
f04183b
to
58418d8
Compare
@lolbinarycat I've matched the fixed behaviour exactly to the old behaviour, which is right above the changed lines. |
both |
Fixes attributes not being shown correctly in rustdoc on re-exports
Does this need to be backported to beta?
r? @jdonszelmann