Skip to content

tidy: move rustdoc js stuff into a tidy extra check #142924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

tidy: move rustdoc js stuff into a tidy extra check #142924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f2661f
tidy: running of eslint, tsc, and es-check are now an extra check
lolbinarycat Jun 23, 2025
adbad90
update CI to use new tidy extra checks for rustdoc js
lolbinarycat Jun 23, 2025
17aab7b
bootstrap: add build.tidy-extra-checks option
lolbinarycat Jun 23, 2025
36cd096
bootstrap: add CONFIG_CHANGE_HISTORY entry for build.tidy-extra-checks
lolbinarycat Jun 24, 2025
ec37d89
tidy: use a lockfile for js tools instead of npx
lolbinarycat Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ __pycache__/

## Node
node_modules
package-lock.json
package.json
/src/doc/rustc-dev-guide/mermaid.min.js

## Rustdoc GUI tests
Expand Down
9 changes: 9 additions & 0 deletions bootstrap.example.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,15 @@
# Whether to use the precompiled stage0 libtest with compiletest.
#build.compiletest-use-stage0-libtest = true

# Default value for the `--extra-checks` flag of tidy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is becoming quite large, and this looks quite self-contained (and useful on its own). Could you please land it separately?

#
# See `./x test tidy --help` for details.
#
# Note that if any value is manually given to bootstrap such as
# `./x test tidy --extra-checks=js`, this value is ignored.
# Use `--extra-checks=''` to temporarily disable all extra checks.
#build.tidy-extra-checks = ""

# Indicates whether ccache is used when building certain artifacts (e.g. LLVM).
# Set to `true` to use the first `ccache` in PATH, or set an absolute path to use
# a specific version.
Expand Down
Loading
Loading