Skip to content

Fix tests/ui/abi/debug.rs for RISC-V #141979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Fix tests/ui/abi/debug.rs for RISC-V #141979

wants to merge 0 commits into from
+0 −0

Conversation

YingkaiLi-VM
Copy link

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jun 3, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 3, 2025
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 3, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@workingjubilee
Copy link
Member

r? @workingjubilee

sorry for not reviewing your PR yet, @beetrees, but can you check if this would overlap with #139340

@rustbot rustbot assigned workingjubilee and unassigned fee1-dead Jun 3, 2025
@beetrees
Copy link
Contributor

beetrees commented Jun 3, 2025

This is unrelated: #139340 is about structs with floating point fields passed via the "C" ABI, whereas #141972 is about integers being passed with the "Rust" ABI.

@workingjubilee
Copy link
Member

@YingkaiLi-VM please rebase on the current master branch

@workingjubilee workingjubilee removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 4, 2025
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2025
@bors
Copy link
Collaborator

bors commented Jun 9, 2025

☔ The latest upstream changes (presumably #142220) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 9, 2025
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added the has-merge-commits PR has merge commits, merge with caution. label Jun 11, 2025
@rustbot rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 11, 2025
@YingkaiLi-VM
Copy link
Author

@bors @workingjubilee Okay，Merge conflicts resolved. Thanks for your help!

@jieyouxu
Copy link
Member

@rustbot review

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 15, 2025
@workingjubilee
Copy link
Member

I don't really want to see a test that doesn't necessarily run and doesn't get blessed.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 17, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@YingkaiLi-VM
Copy link
Author

@workingjubilee Hello, following the approach you suggested, there's a discrepancy in the expected test output. Is this an issue?
wechat_2025-06-30_101639_038

@YingkaiLi-VM
Copy link
Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 30, 2025
@YingkaiLi-VM
Copy link
Author

@workingjubilee Hello, following the approach you suggested, there's a discrepancy in the expected test output. Is this an issue? wechat_2025-06-30_101639_038

Currently I'm not sure if this is a bug, but the expected test output differs between when cross-compilation is enabled and when it's disabled. How should this issue be resolved? If it's confirmed to be a bug, I'd be willing to investigate and try to fix what's causing the problem.

@workingjubilee
Copy link
Member

@YingkaiLi-VM You haven't pushed your intermediate work state so I can't review it.

@workingjubilee
Copy link
Member

@YingkaiLi-VM I can easily tell you how to fix it if you push the actual changes you have made, but 90% of the miscommunication is because you have not.

You leave subtle but key things out of your description because you don't know what is an important detail. So I try to respond based on incomplete information, but I know I am missing key components.

@YingkaiLi-VM
Copy link
Author

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2025
@bors
Copy link
Collaborator

bors commented Jul 3, 2025

☔ The latest upstream changes (presumably #143363) made this pull request unmergeable. Please resolve the merge conflicts.

@YingkaiLi-VM
Copy link
Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 4, 2025
@YingkaiLi-VM
Copy link
Author

@workingjubilee I apologize, that was my oversight. I was too focused on the expected output discrepancies for the TestAbiEqNonsense test.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
workingjubilee
workingjubilee reviewed Jul 4, 2025
View reviewed changes
workingjubilee
workingjubilee reviewed Jul 4, 2025
View reviewed changes
workingjubilee
workingjubilee reviewed Jul 4, 2025
View reviewed changes
@workingjubilee workingjubilee changed the title Attempted to fix #141972 Parameter ABI inconsistency error in Rust for RISC-V Fix tests/ui/abi/debug.rs for RISC-V Jul 4, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 5, 2025
@workingjubilee
Copy link
Member

Ugh. That wasn't supposed to happen.

@workingjubilee workingjubilee mentioned this pull request Jul 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee left review comments

Assignees

@workingjubilee workingjubilee

Labels
O-riscv Target: RISC-V architecture T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@YingkaiLi-VM @rustbot @rust-log-analyzer @workingjubilee @beetrees @bors @jieyouxu @fee1-dead