Skip to content

[win] Use a dash instead of slash for linker to avoid breaking lld #140977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[win] Use a dash instead of slash for linker to avoid breaking lld #140977

wants to merge 1 commit into from
+1 −1

Conversation

dpaoliello
Copy link
Contributor

@dpaoliello dpaoliello commented May 13, 2025 •
edited
Loading

#140758 added the /arm64hazardfree linker arg for aarch64-pc-windows-msvc, unfortunately this breaks linking with lld as it 1) doesn't understand the arguments and 2) assumes that unknown args that start with / are input files.

Fix is to use a dash for the arg: -arm64hazardfree

r? @wesleywiser

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 13, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

@dpaoliello
Copy link
Contributor Author

r? @jieyouxu

(Sorry, referenced the wrong PR as causing the regression)

@rustbot rustbot assigned jieyouxu and unassigned wesleywiser May 13, 2025
@dpaoliello dpaoliello mentioned this pull request May 13, 2025
Merged
jieyouxu
jieyouxu approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

r? jieyouxu @bors r+ rollup

@rustbot

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented May 14, 2025

📌 Commit a1ea0ce has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2025
@bors
Copy link
Collaborator

bors commented May 14, 2025

⌛ Testing commit a1ea0ce with merge 55429e2...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2025
@bors
Auto merge of rust-lang#140977 - dpaoliello:dash, r=jieyouxu
55429e2 
[win] Use a dash instead of slash for linker to avoid breaking lld

rust-lang#140758 added the `/arm64hazardfree` linker arg for aarch64-pc-windows-msvc, unfortunately this breaks linking with `lld` as it 1) doesn't understand the arguments and 2) assumes that unknown args that start with `/` are input files.

Fix is to use a dash for the arg: `-arm64hazardfree`

r? `@wesleywiser`
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
test [rustdoc] tests\rustdoc\private\files-creation-private.rs ... FAILED
test [rustdoc] tests\rustdoc\private\hidden-private.rs ... FAILED
test [rustdoc] tests\rustdoc\private\inline-private-with-intermediate-doc-hidden.rs ... FAILED
test [rustdoc] tests\rustdoc\private\inner-private-110422.rs ... FAILED
test [rustdoc] tests\rustdoc\private\macro-document-private-duplicate.rs ... ignored, ignored always ((fa2025-05-14T07:38:33.7790497Z ##[error]There is not enough space on the disk. : 'C:\actions-runner\cached\_diag\blocks\5e069e9a-a3b8-445c-8b4c-268021635ec2_27eb41a7-2ed4-56f7-ee04-8c5e17bd5c5c.2'
##[error]There is not enough space on the disk. : 'C:\actions-runner\cached\_diag\pages\5e069e9a-a3b8-445c-8b4c-268021635ec2_ccc4059e-4ea2-4996-9631-737428769f20_1.log'

@bors
Copy link
Collaborator

bors commented May 14, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 14, 2025
@jieyouxu
Copy link
Member

@bors retry (not enough space)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2025
jieyouxu added a commit to jieyouxu/rust that referenced this pull request May 14, 2025
@jieyouxu
Rollup merge of rust-lang#140977 - dpaoliello:dash, r=jieyouxu
641d66c 
[win] Use a dash instead of slash for linker to avoid breaking lld

rust-lang#140758 added the `/arm64hazardfree` linker arg for aarch64-pc-windows-msvc, unfortunately this breaks linking with `lld` as it 1) doesn't understand the arguments and 2) assumes that unknown args that start with `/` are input files.

Fix is to use a dash for the arg: `-arm64hazardfree`

r? `@wesleywiser`
@jieyouxu jieyouxu mentioned this pull request May 14, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2025
@bors
Auto merge of rust-lang#140993 - jieyouxu:rollup-rb13gfl, r=jieyouxu
3c15a9d 
Rollup of 4 pull requests

Successful merges:

 - rust-lang#140953 (Fix a compiletest blessing message)
 - rust-lang#140973 (Update rustix to 1.0.7 for bootstrap)
 - rust-lang#140976 (Add `Ipv4Addr` and `Ipv6Addr` diagnostic items)
 - rust-lang#140977 ([win] Use a dash instead of slash for linker to avoid breaking lld)

r? `@ghost`
`@rustbot` modify labels: rollup
@glandium
Copy link
Contributor

Fix is to use a dash for the arg: -arm64hazardfree

For a value of "fix" that means lld emitting a warning about an unknown argument.

compiler-errors added a commit to compiler-errors/rust that referenced this pull request May 15, 2025
@compiler-errors
Rollup merge of rust-lang#140977 - dpaoliello:dash, r=jieyouxu
a933842 
[win] Use a dash instead of slash for linker to avoid breaking lld

rust-lang#140758 added the `/arm64hazardfree` linker arg for aarch64-pc-windows-msvc, unfortunately this breaks linking with `lld` as it 1) doesn't understand the arguments and 2) assumes that unknown args that start with `/` are input files.

Fix is to use a dash for the arg: `-arm64hazardfree`

r? `@wesleywiser`
@compiler-errors compiler-errors mentioned this pull request May 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dpaoliello @rustbot @jieyouxu @bors @rust-log-analyzer @glandium @wesleywiser