Skip to content

Update cargo #140876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025
Merged

Update cargo #140876

merged 1 commit into from
May 10, 2025

Conversation

weihanglo
Copy link
Member

25 commits in 7918c7eb59614c39f1c4e27e99d557720976bdd7..056f5f4f3c100cb36b5e9aed2d20b9ea70aae295
2025-04-27 09:44:23 +0000 to 2025-05-09 14:54:18 +0000

r? ghost

@rustbot
Copy link
Collaborator

rustbot commented May 9, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 9, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented May 9, 2025

📌 Commit 88781bc has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2025
@bors
Copy link
Collaborator

bors commented May 10, 2025

⌛ Testing commit 88781bc with merge c6faa1b...

@bors
Copy link
Collaborator

bors commented May 10, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing c6faa1b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 10, 2025
@bors bors merged commit c6faa1b into rust-lang:master May 10, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 10, 2025
@weihanglo weihanglo deleted the update-cargo branch May 10, 2025 06:13
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing fd9fad6 (parent) -> c6faa1b (this PR)

Test differences

Show 33205 test diffs

Stage 1

  • bit_set::tests::bench_remove: pass -> [missing] (J0)
  • clean::types::tests::is_same_generic: pass -> [missing] (J0)
  • errors::verify_codegen_ssa_invalid_monomorphization_invalid_bitmask_101: pass -> [missing] (J0)
  • errors::verify_codegen_ssa_link_script_unavailable_63: pass -> [missing] (J0)
  • errors::verify_const_eval_nested_static_in_thread_local_1: pass -> [missing] (J0)
  • errors::verify_parse_binder_and_polarity_174: pass -> [missing] (J0)
  • errors::verify_parse_expr_rarrow_call_170: pass -> [missing] (J0)
  • errors::verify_passes_should_be_applied_to_struct_enum_15: pass -> [missing] (J0)
  • spec::tests::powerpc64_unknown_freebsd: pass -> [missing] (J0)
  • tests::format_type: pass -> [missing] (J0)
  • tests::test_fn_like_mk_idents: pass -> [missing] (J0)
  • tests::test_unused: pass -> [missing] (J0)
  • theme::tests::test_media: pass -> [missing] (J0)
  • atomic::uint_or: pass -> [missing] (J1)
  • collections::binary_heap::test_to_vec: pass -> [missing] (J1)
  • collections::btree::map::tests::test_range_finding_ill_order_in_range_ord: pass -> [missing] (J1)
  • collections::hash::map::tests::test_extract_if::consuming_all: pass -> [missing] (J1)
  • dynamic_tests::hashmap: pass -> [missing] (J1)
  • ffi::os_str::tests::slice_out_of_bounds: pass -> [missing] (J1)
  • ffi::os_str::tests::test_os_str_default: pass -> [missing] (J1)
  • hash::sip::test_hash_no_bytes_dropped_32: pass -> [missing] (J1)
  • into: pass -> [missing] (J1)
  • iter::adapters::filter_map::test_double_ended_filter_map: pass -> [missing] (J1)
  • mpmc::oneshot_single_thread_try_recv_open: pass -> [missing] (J1)
  • mpsc_sync::oneshot_single_thread_try_send_closed2: pass -> [missing] (J1)
  • mpsc_sync::port_gone_concurrent_shared: pass -> [missing] (J1)
  • num::i16::test_from_str_radix: pass -> [missing] (J1)
  • num::i32::test_swap_bytes: pass -> [missing] (J1)
  • num::i64::test_swap_bytes: pass -> [missing] (J1)
  • num::i8::test_le: pass -> [missing] (J1)
  • num::u16::test_isolate_least_significant_one: pass -> [missing] (J1)
  • num::u32::test_unbounded_shr: pass -> [missing] (J1)
  • ptr::test_ptr_metadata_in_const: pass -> [missing] (J1)
  • ptr::test_unsized_nonnull: pass -> [missing] (J1)
  • slice::select_nth_unstable_zero_length: pass -> [missing] (J1)
  • slice::test_chunks_iterator_0: pass -> [missing] (J1)
  • str::test_replace: pass -> [missing] (J1)
  • sys_common::wtf8::tests::wtf8buf_truncate_fail_code_point_boundary: pass -> [missing] (J1)
  • ascii::medium::case02_lookup_table: pass -> [missing] (J2)
  • btree::map::clone_slim_100_and_clear: pass -> [missing] (J2)
  • btree::set::difference_random_100_vs_10k: pass -> [missing] (J2)
  • iter::bench_enumerate_chain_ref_sum: pass -> [missing] (J2)
  • slice::split_off_oob_max_range_to_inclusive: pass -> [missing] (J2)
  • sort::tests::stable::self_cmp_i32_random_d20: pass -> [missing] (J2)
  • str::split_ad_str::short_ascii: pass -> [missing] (J2)
  • sort::tests::stable::panic_observable_is_less_random: ignore -> [missing] (J3)
  • sort::tests::unstable::correct_string_ascending: ignore -> [missing] (J3)
  • sort::tests::unstable::self_cmp_i32_random_d20: ignore -> [missing] (J3)
  • os::unix::net::tests::test_abstract_name_too_long: pass -> [missing] (J4)

Stage 2

  • errors::verify_ast_passes_forbidden_const_param_2: [missing] -> pass (J0)
  • errors::verify_codegen_ssa_invalid_monomorphization_unrecognized_intrinsic_94: [missing] -> pass (J0)
  • errors::verify_incremental_create_lock_23: [missing] -> pass (J0)
  • errors::verify_passes_params_not_allowed_133: [missing] -> pass (J0)
  • errors::verify_resolve_extern_crate_loading_macro_not_at_crate_root_35: [missing] -> pass (J0)
  • errors::verify_session_profile_use_file_does_not_exist_4: [missing] -> pass (J0)
  • errors::verify_trait_selection_rustc_on_unimplemented_expected_one_predicate_in_not_11: [missing] -> pass (J0)
  • leb128::tests::test_u32_leb128: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_multiple_item_2: [missing] -> pass (J0)
  • spec::tests::m68k_unknown_linux_gnu: [missing] -> pass (J0)
  • spec::tests::riscv64gc_unknown_netbsd: [missing] -> pass (J0)
  • tests::test_valid_shebang: [missing] -> pass (J0)
  • ascii::test_is_ascii_hexdigit: [missing] -> pass (J1)
  • cell::unsafe_cell_unsized: [missing] -> pass (J1)
  • collections::btree::map::tests::test_cursor_mut_insert_before_3: [missing] -> pass (J1)
  • collections::hash::map::tests::test_extract_if::mutating_and_keeping: [missing] -> pass (J1)
  • f32::test_acosh: [missing] -> pass (J1)
  • fmt::builders::debug_list::test_nested: [missing] -> pass (J1)
  • fmt::builders::debug_set::test_multiple: [missing] -> pass (J1)
  • fmt::test_once: [missing] -> pass (J1)
  • io::buffered::tests::bufreader_full_initialize: [missing] -> pass (J1)
  • io::buffered::tests::line_buffer_write0_normal: [missing] -> pass (J1)
  • mpsc::recv_from_outside_runtime: [missing] -> pass (J1)
  • net::ip_addr::test_from_str_ipv4_in_ipv6: [missing] -> pass (J1)
  • net::socket_addr::socket_v6_to_str: [missing] -> pass (J1)
  • num::i128::test_overflows: [missing] -> pass (J1)
  • num::i32::test_isolate_least_significant_one: [missing] -> pass (J1)
  • num::i8::test_be: [missing] -> pass (J1)
  • num::test_try_i32i8: [missing] -> pass (J1)
  • option::test_replace: [missing] -> pass (J1)
  • slice::test_from_fn: [missing] -> pass (J1)
  • slice::test_get_disjoint_mut_range_empty_at_edge: [missing] -> pass (J1)
  • str::slice_index::boundary::rangeinclusive_1::index_fail: [missing] -> pass (J1)
  • str_lossy::chunks: [missing] -> pass (J1)
  • sys_common::wtf8::tests::wobbled_wtf8_plus_str_isnt_utf8: [missing] -> pass (J1)
  • sys_common::wtf8::tests::wtf8_to_ascii_lowercase: [missing] -> pass (J1)
  • sys_common::wtf8::tests::wtf8buf_push_str: [missing] -> pass (J1)
  • thin_box::align2_size_not_pow2: [missing] -> pass (J1)
  • thin_box::align2big: [missing] -> pass (J1)
  • vec::test_flatten_clone: [missing] -> pass (J1)
  • ascii::medium::case04_branch_and_mask: [missing] -> pass (J2)
  • btree::map::find_seq_100: [missing] -> pass (J2)
  • net::tcp::tests::socket_and_peer_name: [missing] -> pass (J2)
  • num::int_log::u32_log10_random: [missing] -> pass (J2)
  • num::int_sqrt::u128_sqrt_random: [missing] -> pass (J2)
  • sort::tests::stable::panic_retain_orig_set_i32_saw_mixed: [missing] -> pass (J2)
  • str::debug::ascii_escapes: [missing] -> pass (J2)
  • str::find_underscore_char::short_mixed: [missing] -> pass (J2)
  • str::split_a_str::long_lorem_ipsum: [missing] -> pass (J2)
  • sort::tests::stable::correct_1k_random: [missing] -> ignore (J3)
  • sort::tests::stable::correct_string_ascending: [missing] -> ignore (J3)

(and 16557 additional test diffs)

Additionally, 16548 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard c6faa1b22e735494677a2410ee281ca5f646e747 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 4681.8s -> 1592.0s (-66.0%)
  2. test-various: 4082.2s -> 2295.1s (-43.8%)
  3. dist-x86_64-apple: 7822.2s -> 10805.0s (38.1%)
  4. x86_64-gnu-aux: 6578.4s -> 4179.3s (-36.5%)
  5. aarch64-apple: 4308.0s -> 3429.0s (-20.4%)
  6. dist-apple-various: 6393.5s -> 7302.4s (14.2%)
  7. x86_64-msvc-1: 9470.7s -> 8631.1s (-8.9%)
  8. x86_64-apple-1: 6299.9s -> 6727.5s (6.8%)
  9. aarch64-gnu: 6778.4s -> 6457.0s (-4.7%)
  10. dist-powerpc64-linux: 5322.6s -> 5506.7s (3.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c6faa1b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.1% [0.4%, 5.7%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.5% [-0.6%, -0.4%] 4
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.7% [-0.6%, 5.7%] 6

Cycles

Results (primary 0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.1% [0.4%, 2.1%] 6
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.7% [-1.8%, -0.4%] 6
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.2% [-1.8%, 2.1%] 12

Binary size

Results (secondary -0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.0% [-0.0%, -0.0%] 2
All ❌✅ (primary) - - 0

Bootstrap: 773.683s -> 773.028s (-0.08%)
Artifact size: 365.66 MiB -> 365.81 MiB (0.04%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants