-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unstable --print=crate-root-lint-levels
#139184
Merged
Merged
+213
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR modifies cc @jieyouxu |
3 tasks
This comment has been minimized.
This comment has been minimized.
7c6f565
to
ecf46ff
Compare
This comment has been minimized.
This comment has been minimized.
ecf46ff
to
bf62be2
Compare
This comment has been minimized.
This comment has been minimized.
bf62be2
to
831a158
Compare
jieyouxu
reviewed
Apr 1, 2025
src/doc/unstable-book/src/compiler-flags/print-crate-root-lint-levels.md
Outdated
Show resolved
Hide resolved
831a158
to
df18de5
Compare
jieyouxu
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this LGTM mostly, have a few more questions
src/doc/unstable-book/src/compiler-flags/print-crate-root-lint-levels.md
Show resolved
Hide resolved
src/doc/unstable-book/src/compiler-flags/print-crate-root-lint-levels.md
Show resolved
Hide resolved
jieyouxu
reviewed
Apr 1, 2025
src/doc/unstable-book/src/compiler-flags/print-crate-root-lint-levels.md
Show resolved
Hide resolved
@rustbot author |
Reminder, once the PR becomes ready for a review, use |
@bors r+ rollup |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 2, 2025
…eyouxu Add unstable `--print=crate-root-lint-levels` This PR implements `--print=crate-root-lint-levels` from MCP 833 rust-lang/compiler-team#833. Tracking issue: rust-lang#139180 Best reviewed commit by commit.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 2, 2025
Rollup of 5 pull requests Successful merges: - rust-lang#139178 (Remove cjgillot from automated review assignment) - rust-lang#139184 (Add unstable `--print=crate-root-lint-levels`) - rust-lang#139215 (Add `opt-level = "s"` for more std symbolication crates) - rust-lang#139232 (Move methods from `Map` to `TyCtxt`, part 5.) - rust-lang#139239 (Remove `aux_build` run-make rustc helpers) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 2, 2025
Rollup merge of rust-lang#139184 - Urgau:crate-root-lint-levels, r=jieyouxu Add unstable `--print=crate-root-lint-levels` This PR implements `--print=crate-root-lint-levels` from MCP 833 rust-lang/compiler-team#833. Tracking issue: rust-lang#139180 Best reviewed commit by commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-run-make
Area: port run-make Makefiles to rmake.rs
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
--print=crate-root-lint-levels
from MCP 833 rust-lang/compiler-team#833.Tracking issue: #139180
Best reviewed commit by commit.