Code

Clippy subtree update#138761

Code

Merged

bors merged 149 commits intorust-lang:masterrust-lang/rust:masterfrom

flip1995:clippy-subtree-updateflip1995/rust:clippy-subtree-updateCopy head branch name to clipboard

Mar 21, 2025

Commits

Commits on Feb 4, 2025

• needless_collect: avoid warning if non-iterator methods are used

  Show description for c012693
  notriddle

  committed
  c012693

  Copy full SHA for c012693

Commits on Feb 15, 2025

• `comparison_chain`: `style` → `pedantic`

  Show description for 287a942
  samueltardieu

  committed
  287a942

  Copy full SHA for 287a942

Commits on Feb 17, 2025

• needless_collect: look through assignments, not just declarations

  notriddle

  committed
  6321ac7

  Copy full SHA for 6321ac7

Commits on Feb 19, 2025

• Remove Known problems section for vec_box

  alex-semenyuk

  authored
  e297c84

  Copy full SHA for e297c84

Commits on Feb 22, 2025

• fix suggestion for assignments wrapped in parentheses under `needless_late_init`

  lapla-cogito

  committed
  af40c23

  Copy full SHA for af40c23

Commits on Feb 26, 2025

• In `AssocOp::AssignOp`, use `BinOpKind` instead of `BinOpToken`

  Show description for 8f001ea
  nnethercote

  committed
  8f001ea

  Copy full SHA for 8f001ea

• Introduce `AssocOp::Binary`.

  Show description for c79a7ed
  nnethercote

  committed
  c79a7ed

  Copy full SHA for c79a7ed

• Replace `AssocOp::DotDot{,Eq}` with `AssocOp::Range`.

  Show description for 6db6a4f
  nnethercote

  committed
  6db6a4f

  Copy full SHA for 6db6a4f

• Rename `AssocOp::As` as `AssocOp::Cast`.

  Show description for 537577f
  nnethercote

  committed
  537577f

  Copy full SHA for 537577f

• Refactor function after adding a new diagnostic item

  Show description for 3a39629
  samueltardieu

  committed
  3a39629

  Copy full SHA for 3a39629

Commits on Feb 27, 2025

• Clean up TypeckResults::extract_binding_mode

  Show description for de25d0d
  meithecatte

  committed
  de25d0d

  Copy full SHA for de25d0d

Commits on Feb 28, 2025

• Rollup merge of #137712 - meithecatte:extract-binding-mode, r=oli-obk

  Show description for 222aaba
  jieyouxu

  authored
  222aaba

  Copy full SHA for 222aaba

• fix: `map_entry` suggest wrongly when key is not `Copy`

  profetia

  committed
  18616dc

  Copy full SHA for 18616dc

• `incompatible_msrv`: lint function calls with any argument count

  Show description for 4f0e507
  samueltardieu

  committed
  4f0e507

  Copy full SHA for 4f0e507

• Merge commit '9f9a822509e5ad3e560cbbe830d1013f936fca28' into clippy-subtree-update

  flip1995

  committed
  fe01c44

  Copy full SHA for fe01c44

• Clippy: skip check_host_compiler check in rustc testsuite

  Show description for a6a78e1
  flip1995

  committed
  a6a78e1

  Copy full SHA for a6a78e1

• Fix link to ty::Ty in clippy_utils

  flip1995

  committed
  870f395

  Copy full SHA for 870f395

• Extend `{implicit,inverted}_saturating_sub` to expressions

  Show description for 60e1d7e
  samueltardieu

  committed
  60e1d7e

  Copy full SHA for 60e1d7e

• Apply `implicit_saturating_sub` to Clippy sources

  samueltardieu

  committed
  029a6db

  Copy full SHA for 029a6db

Commits on Mar 1, 2025

• Extend `{implicit,inverted}_saturating_sub` to expressions (#14310)

  Show description for 8178530
  llogiq

  authored
  8178530

  Copy full SHA for 8178530

• Suggest using `#[expect]` to check lint positioning

  Show description for e15b9a0
  samueltardieu

  committed
  e15b9a0

  Copy full SHA for e15b9a0

• Suggest using `#[expect]` to check lint positioning (#14327)

  Show description for 1419ac2
  xFrednet

  authored
  1419ac2

  Copy full SHA for 1419ac2

• new lint: `doc_comment_double_space_linebreak`

  Show description for f94f64f
  

  Jacherr

  authored and

  xFrednet

  committed
  f94f64f

  Copy full SHA for f94f64f

• `doc_comment_double_space_linebreaks`: lint per line instead of by block

  Show description for 2fd51b8
  

  Jacherr

  authored and

  xFrednet

  committed
  2fd51b8

  Copy full SHA for 2fd51b8

• `doc_comment_double_space_linebreak`: Use multi spans and suggestions

  xFrednet

  committed
  60191cf

  Copy full SHA for 60191cf

• Rename `doc_comment_double_space_linebreak` -> `doc_comment_double_space_linebreaks`

  xFrednet

  committed
  7fe160a

  Copy full SHA for 7fe160a

• `doc_comment_double_space_linebreaks`: Fix tests

  xFrednet

  committed
  45e4487

  Copy full SHA for 45e4487

• fix [`undocumented_unsafe_blocks`] FP with trait/impl items

  

  J-ZhengLi

  authored and

  profetia

  committed
  d395646

  Copy full SHA for d395646

• Use inner span in `undocumented_unsafe_blocks`

  profetia

  committed
  91d20cb

  Copy full SHA for 91d20cb

• fix `undocumented_unsafe_blocks` FP in long assignment

  profetia

  committed
  3899488

  Copy full SHA for 3899488

• Add regression test for #11709

  profetia

  committed
  d027ca9

  Copy full SHA for d027ca9

• rename the MSRV alias `MANUAL_DIV_CEIL` to `DIV_CEIL`

  lapla-cogito

  committed
  6537f93

  Copy full SHA for 6537f93

• `comparison_chain`: `style` → `pedantic` (#14219)

  Show description for 35746de
  llogiq

  authored
  35746de

  Copy full SHA for 35746de

• Implment `#[cfg]` and `#[cfg_attr]` in `where` clauses

  frank-king

  committed
  cac9e0a

  Copy full SHA for cac9e0a

• fix: `undocumented_unsafe_blocks` FP on trait/impl items (#13888)

  Show description for 62f34f2
  xFrednet

  authored
  62f34f2

  Copy full SHA for 62f34f2

Commits on Mar 2, 2025

• Lint more cases of `ptr::eq()`

  Show description for d7d0abd
  samueltardieu

  committed
  d7d0abd

  Copy full SHA for d7d0abd

• Apply `ptr_eq` lint only if `cmp_null` is not applicable

  Show description for 336d344
  samueltardieu

  committed
  336d344

  Copy full SHA for 336d344

• fix: `map_entry` suggest wrongly when key is not `Copy` (#14314)

  Show description for aa2180f
  blyxyas

  authored
  aa2180f

  Copy full SHA for aa2180f

• needless_collect: avoid warning if non-iterator methods are used (#14147)

  Show description for a9c61ec
  blyxyas

  authored
  a9c61ec

  Copy full SHA for a9c61ec

Commits on Mar 3, 2025

• fix: `manual_let_else` missing binding mode

  profetia

  committed
  68679f2

  Copy full SHA for 68679f2

• Remove some unnecessary aliases from `rustc_data_structures::sync`

  Show description for ddc9f45
  Zalathar

  committed
  ddc9f45

  Copy full SHA for ddc9f45

• Rollup merge of #132388 - frank-king:feature/where-cfg, r=petrochenkov

  Show description for c94576e
  matthiaskrgr

  authored
  c94576e

  Copy full SHA for c94576e

• add `macos-latest` as a CI target

  lapla-cogito

  committed
  d63d56a

  Copy full SHA for d63d56a

Commits on Mar 4, 2025

• Auto merge of #137959 - matthiaskrgr:rollup-62vjvwr, r=matthiaskrgr

  Show description for 1f0d057
  bors

  committed
  1f0d057

  Copy full SHA for 1f0d057

• Use the latest nightly rust to run linkcheck

  samueltardieu

  committed
  4141362

  Copy full SHA for 4141362

• Use the latest nightly rust to run linkcheck (#14348)

  Show description for b4b7c7b
  flip1995

  authored
  b4b7c7b

  Copy full SHA for b4b7c7b

• Lint more cases with `ptr_eq` (#14339)

  Show description for cdc1d9d
  flip1995

  authored
  cdc1d9d

  Copy full SHA for cdc1d9d

• better help for `mixed_case_hex_literals`

  lapla-cogito

  committed
  e587a5d

  Copy full SHA for e587a5d

• don't trigger `unnecessary_debug_formatting` in tests

  lapla-cogito

  committed
  e6a4cf6

  Copy full SHA for e6a4cf6

• Create helper function to suggest a candidate in case of a typo

  decryphe

  committed
  9f0d819

  Copy full SHA for 9f0d819

• Make alphabetic ordering in module item groups configurable (new default: off)

  Show description for 5df6887
  decryphe

  committed
  5df6887

  Copy full SHA for 5df6887

• Walk back to the root context to compute the span

  Show description for 9275ae9
  samueltardieu

  committed
  9275ae9

  Copy full SHA for 9275ae9

• better help for `mixed_case_hex_literals` (#14235)

  Show description for dd8cf05
  Alexendoo

  authored
  dd8cf05

  Copy full SHA for dd8cf05

• don't trigger `unnecessary_debug_formatting` in tests (#14347)

  Show description for 2440f51
  Centri3

  authored
  2440f51

  Copy full SHA for 2440f51

• Make `struct_field_names` lint on private fields of public structs.

  Show description for 2067375
  kpreid

  committed
  2067375

  Copy full SHA for 2067375

• Move `check_variant()` code into a method of `ItemNameRepetitions` too.

  kpreid

  committed
  8c73b76

  Copy full SHA for 8c73b76

Commits on Mar 5, 2025

• Walk back to the root context to compute the span (#14349)

  Show description for 9538e5b
  llogiq

  authored
  9538e5b

  Copy full SHA for 9538e5b

• Use size_of from the prelude instead of imported

  Show description for e8cd3d4
  thaliaarchi

  committed
  e8cd3d4

  Copy full SHA for e8cd3d4

• Remove Known problems section for `vec_box` (#14252)

  Show description for 8108bd8
  Alexendoo

  authored
  8108bd8

  Copy full SHA for 8108bd8

• fix incorrect suggestions related to parentheses in `needless_return`

  lapla-cogito

  committed
  1cd7022

  Copy full SHA for 1cd7022

• Use `size_of` from the prelude instead of imported (#14355)

  Show description for ad633be
  Centri3

  authored
  ad633be

  Copy full SHA for ad633be

• Refactor function after adding a new diagnostic item (#14306)

  Show description for 06e7590
  Centri3

  authored
  06e7590

  Copy full SHA for 06e7590

• Make `struct_field_names` check private fields of public structs. (#14076)

  Show description for 231bf45
  Centri3

  authored
  231bf45

  Copy full SHA for 231bf45

• add `is_expr_temporary_value` helper function

  lapla-cogito

  committed
  2fda4f6

  Copy full SHA for 2fda4f6

• apply `is_expr_temporary_value` to Clippy source

  lapla-cogito

  committed
  27e69a8

  Copy full SHA for 27e69a8

• don't call `iter()` on a temporary object in `unnecessary_to_owned`

  lapla-cogito

  committed
  06f797d

  Copy full SHA for 06f797d

• `unnecessary_to_owned`: don't call `iter()` on a temporary object (#14243)

  Show description for 81643e2
  Centri3

  authored
  81643e2

  Copy full SHA for 81643e2

Commits on Mar 6, 2025

• fix: `missing_const_for_fn` FP on unstable const traits

  profetia

  committed
  a028651

  Copy full SHA for a028651

• Remove the `Option` part of range ends in the HIR

  oli-obk

  committed
  e5c1d1c

  Copy full SHA for e5c1d1c

• docs: update rationale for excessive-bools

  Show description for cc6127b
  therewillbecode

  committed
  cc6127b

  Copy full SHA for cc6127b

• docs: update rationale for excessive-bools (#14351)

  Show description for cee9abf
  blyxyas

  authored
  cee9abf

  Copy full SHA for cee9abf

• Fix clippy

  spastorino

  committed
  d52ac1b

  Copy full SHA for d52ac1b

Commits on Mar 7, 2025

• Make synthetic RPITIT assoc ty name handling more rigorous.

  Show description for cf07525
  nnethercote

  committed
  cf07525

  Copy full SHA for cf07525

• Rollup merge of #134797 - spastorino:ergonomic-ref-counting-1, r=nikomatsakis

  Show description for c919de7
  matthiaskrgr

  authored
  c919de7

  Copy full SHA for c919de7

• Rollup merge of #137977 - nnethercote:less-kw-Empty-1, r=spastorino

  Show description for eac092f
  matthiaskrgr

  authored
  eac092f

  Copy full SHA for eac092f

Commits on Mar 8, 2025

• rename the MSRV alias `MANUAL_DIV_CEIL` to `DIV_CEIL` (#14329)

  Show description for 19930f9
  dswij

  authored
  19930f9

  Copy full SHA for 19930f9

• fix: `manual_let_else` missing binding mode (#14204)

  Show description for f83c94c
  dswij

  authored
  f83c94c

  Copy full SHA for f83c94c

• don't trigger `blocks_in_conditions` when the condition contains a `return`

  lapla-cogito

  committed
  243e0ee

  Copy full SHA for 243e0ee

• Improve `needless_pass_by_value` suggestion

  GuillaumeGomez

  committed
  79013f8

  Copy full SHA for 79013f8

• Update `needless_pass_by_value` stderr

  GuillaumeGomez

  committed
  c8e47f9

  Copy full SHA for c8e47f9

Commits on Mar 9, 2025

• don't trigger `blocks_in_conditions` when the condition contains a `return` (#14338)

  Show description for 1b62885
  Manishearth

  authored
  1b62885

  Copy full SHA for 1b62885

• fix broken CSS links

  lapla-cogito

  committed
  ab21f71

  Copy full SHA for ab21f71

• Add documentation to json.rs module

  Turtel216

  committed
  8dd65e4

  Copy full SHA for 8dd65e4

• Fix key function description

  Turtel216

  committed
  184feee

  Copy full SHA for 184feee

• fix broken theme CSS links in the website (#14379)

  Show description for 7bae269
  Alexendoo

  authored
  7bae269

  Copy full SHA for 7bae269

• docs: Add documentation to json.rs module (#14383)

  Show description for 3d775b3
  Manishearth

  authored
  3d775b3

  Copy full SHA for 3d775b3

• `arbitrary_source_item_ordering`: Make alphabetic ordering in module item groups optional (#13718)

  Show description for 819f3c7
  y21

  authored
  819f3c7

  Copy full SHA for 819f3c7

Commits on Mar 10, 2025

• fix: `unnecessary_safety_comment` FP on desugared assign

  profetia

  committed
  97275d5

  Copy full SHA for 97275d5

• make `never_loop` applicability more flexible

  lapla-cogito

  committed
  90dbc5b

  Copy full SHA for 90dbc5b

• Improve `needless_pass_by_value` suggestion (#13880)

  Show description for a25cbd5
  flip1995

  authored
  a25cbd5

  Copy full SHA for a25cbd5

Commits on Mar 11, 2025

• Implement `#[define_opaque]` attribute for functions.

  oli-obk

  committed
  cb044d4

  Copy full SHA for cb044d4

• add `macos-latest` as a CI target (#14342)

  Show description for a5bc316
  flip1995

  authored
  a5bc316

  Copy full SHA for a5bc316

• Add missing tests annotations for `ui-internal`

  GuillaumeGomez

  committed
  cb9682b

  Copy full SHA for cb9682b

• Add missing tests annotations for `ui-internal` (#14388)

  Show description for 8f280ff
  flip1995

  authored
  8f280ff

  Copy full SHA for 8f280ff

• Move methods from `Map` to `TyCtxt`, part 4.

  Show description for 650b7d9
  nnethercote

  committed
  650b7d9

  Copy full SHA for 650b7d9

Commits on Mar 12, 2025

• fix: `unnecessary_safety_comment` FP on desugared assign (#14371)

  Show description for 714c64c
  Alexendoo

  authored
  714c64c

  Copy full SHA for 714c64c

• `needless_pass_by_value`: reference the innermost `Option` content

  Show description for 35e6057
  samueltardieu

  committed
  35e6057

  Copy full SHA for 35e6057

• Update `ui_test` version to `0.29.2`

  GuillaumeGomez

  committed
  cfc7432

  Copy full SHA for cfc7432

• Update `produce_ice` so its error can be checked in ui tests

  GuillaumeGomez

  committed
  e4d3b0a

  Copy full SHA for e4d3b0a

• Make annotations mandatory for internal ui tests

  GuillaumeGomez

  committed
  ec8c0b3

  Copy full SHA for ec8c0b3

• Update `lint_message_convention` test to allow clippy "help" message

  GuillaumeGomez

  committed
  092a20e

  Copy full SHA for 092a20e

• Make annotations mandatory for internal ui tests (#14393)

  Show description for 0730678
  flip1995

  authored
  0730678

  Copy full SHA for 0730678

• `needless_pass_by_value`: make verbose suggestion

  Show description for 417d4e6
  samueltardieu

  committed
  417d4e6

  Copy full SHA for 417d4e6

• `needless_pass_by_value`: reference the innermost `Option` content (#14392)

  Show description for 7254072
  flip1995

  authored
  7254072

  Copy full SHA for 7254072

• explain `is_from_proc_macro` in the book

  y21

  committed
  44094e5

  Copy full SHA for 44094e5

• Improve `string_to_string` lint in case it is in a `map` call

  GuillaumeGomez

  committed
  21601fd

  Copy full SHA for 21601fd

• Add ui test for `string_to_string` in map calls

  GuillaumeGomez

  committed
  0ffc6cf

  Copy full SHA for 0ffc6cf

• Update copyright year

  alex-semenyuk

  committed
  559f23e

  Copy full SHA for 559f23e

Commits on Mar 13, 2025

• `incompatible_msrv`: lint function calls with any argument count (#14216)

  Show description for 18061e2
  Centri3

  authored
  18061e2

  Copy full SHA for 18061e2

• Make `string_to_string` emit a suggestion when `cloned` can be used

  GuillaumeGomez

  committed
  0e4b6c8

  Copy full SHA for 0e4b6c8

• Update copyright year (#14399)

  Show description for c07fd48
  Alexendoo

  authored
  c07fd48

  Copy full SHA for c07fd48

• Explain `is_from_proc_macro` and `proc_macros` auxiliary crate in the book (#14398)

  Show description for f85331f
  flip1995

  authored
  f85331f

  Copy full SHA for f85331f

Commits on Mar 14, 2025

• Do not suggest using `-Zmacro-backtrace` for builtin macros

  Show description for 915e442
  estebank

  committed
  915e442

  Copy full SHA for 915e442

• Add failing from_over_into test case

  KonaeAkira

  committed
  da910b1

  Copy full SHA for da910b1

• Fix from_over_into lint suggesting invalid code

  KonaeAkira

  committed
  4a324c9

  Copy full SHA for 4a324c9

• Simplify implementation

  KonaeAkira

  committed
  9c897a2

  Copy full SHA for 9c897a2

Commits on Mar 15, 2025

• Fix `from_over_into` lint suggesting invalid code (#14409)

  Show description for 5c031d1
  Alexendoo

  authored
  5c031d1

  Copy full SHA for 5c031d1

• Fold visit into ty

  compiler-errors

  committed
  f96eb61

  Copy full SHA for f96eb61

• Auto merge of #138464 - compiler-errors:less-type-ir, r=lcnr

  Show description for f357993
  bors

  committed
  f357993

  Copy full SHA for f357993

• question_mark: suggest `as_ref`/`as_mut` if ref binding is used

  notriddle

  committed
  4e9caa3

  Copy full SHA for 4e9caa3

Commits on Mar 16, 2025

• Remove `@xFrednet` from docs :wave:

  xFrednet

  committed
  9845b10

  Copy full SHA for 9845b10

• new lint: `doc_comment_double_space_linebreaks` (#12876)

  Show description for 3c7dfac
  xFrednet

  authored
  3c7dfac

  Copy full SHA for 3c7dfac

• Remove `@xFrednet` from docs :wave: (#14415)

  Show description for 1617a2e
  xFrednet

  authored
  1617a2e

  Copy full SHA for 1617a2e

• fix incorrect suggestions related to parentheses in `needless_return` (#14094)

  Show description for 775a5c2
  Alexendoo

  authored
  775a5c2

  Copy full SHA for 775a5c2

• Suppress must_use in compiler and tools

  compiler-errors

  committed
  9eab078

  Copy full SHA for 9eab078

• fix: bad indent in doc comments

  Show description for b23fcb0
  tkr-sh

  committed
  b23fcb0

  Copy full SHA for b23fcb0

• Fix `is_relevant_impl`.

  Show description for 2b431f7
  nnethercote

  committed
  2b431f7

  Copy full SHA for 2b431f7

• question_mark: avoid incorrect suggestion when `ref` binding used (#14158)

  Show description for 4800557
  blyxyas

  authored
  4800557

  Copy full SHA for 4800557

Commits on Mar 17, 2025

• fix: `option_if_let_else` FP when value partially moved

  profetia

  committed
  a3865b1

  Copy full SHA for a3865b1

• Reinstate `single_match`/`single_match_else` lints with comments

  Show description for a1bdc19
  samueltardieu

  committed
  a1bdc19

  Copy full SHA for a1bdc19

• Move `hir::Item::ident` into `hir::ItemKind`.

  Show description for 6222a73
  nnethercote

  committed
  6222a73

  Copy full SHA for 6222a73

Commits on Mar 18, 2025

• Leave assignments for now

  Show description for b057ba4
  Centri3

  authored
  b057ba4

  Copy full SHA for b057ba4

• Auto merge of #138630 - matthiaskrgr:rollup-kk1gogr, r=matthiaskrgr

  Show description for 9932e5e
  bors

  committed
  9932e5e

  Copy full SHA for 9932e5e

• Better handle blocks with just one expression

  GuillaumeGomez

  committed
  269b913

  Copy full SHA for 269b913

• Improve `string_to_string` lint in case it is in a map call (#14396)

  Show description for a07e887
  flip1995

  authored
  a07e887

  Copy full SHA for a07e887

• Leave assignments for now (#14428)

  Show description for ea30a09
  blyxyas

  authored
  ea30a09

  Copy full SHA for ea30a09

• Reinstate `single_match`/`single_match_else` lints with comments (#14420)

  Show description for d443f38
  Alexendoo

  authored
  d443f38

  Copy full SHA for d443f38

• fix: bad indent in doc comments (#14419)

  Show description for a422d9e
  Alexendoo

  authored
  a422d9e

  Copy full SHA for a422d9e

Commits on Mar 19, 2025

• Add MSRV check for `question_mark`

  blyxxyz

  committed
  d793c0a

  Copy full SHA for d793c0a

• fix: `option_if_let_else` FP when value partially moved (#14209)

  Show description for 31497d6
  blyxyas

  authored
  31497d6

  Copy full SHA for 31497d6

• Add MSRV check for `question_mark` (#14436)

  Show description for 48ce25e
  Manishearth

  authored
  48ce25e

  Copy full SHA for 48ce25e

• fix suggestion for assignments have enclosing parentheses under `needless_late_init` (#14169)

  Show description for 221ae5f
  y21

  authored
  221ae5f

  Copy full SHA for 221ae5f

Commits on Mar 20, 2025

• make `never_loop` applicability more flexible (#14203)

  Show description for f2feb0f
  y21

  authored
  f2feb0f

  Copy full SHA for f2feb0f

• Merge remote-tracking branch 'upstream/master' into rustup

  flip1995

  committed
  dc4c776

  Copy full SHA for dc4c776

• Bump nightly version -> 2025-03-20

  flip1995

  committed
  a086879

  Copy full SHA for a086879

• Rustup (#14445)

  Show description for d1d0fee
  flip1995

  authored
  d1d0fee

  Copy full SHA for d1d0fee

• fix: `missing_const_for_fn` FP on unstable const traits (#14294)

  Show description for 1e5237f
  y21

  authored
  1e5237f

  Copy full SHA for 1e5237f

• Merge commit '1e5237f4a56ae958af7e5824343eacf737b67083' into clippy-subtree-update

  flip1995

  committed
  ae31f7a

  Copy full SHA for ae31f7a

• Update Cargo.lock

  flip1995

  committed
  58142e9

  Copy full SHA for 58142e9