Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a per-item query just for define_opaque attributes #138500

Closed

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 14, 2025

follow up to #128440 (comment)

This wasn't done in the previous PR to make sure we can gauge the perf effect independently of the other changes

@rustbot
Copy link
Collaborator

rustbot commented Mar 14, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 14, 2025
@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 14, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 14, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2025
…, r=<try>

Add a per-item query just for `define_opaque` attributes

follow up to rust-lang#128440 (comment)

This wasn't done in the previous PR to make sure we can gauge the perf effect independently of the other changes
@bors
Copy link
Collaborator

bors commented Mar 14, 2025

⌛ Trying commit fe58a05 with merge 6bf40d9...

@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 14, 2025
@bors
Copy link
Collaborator

bors commented Mar 14, 2025

☀️ Try build successful - checks-actions
Build commit: 6bf40d9 (6bf40d92f0985ed0954059e0dcfa3d220f802df7)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6bf40d9): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
0.3% [0.1%, 0.6%] 34
Regressions ❌
(secondary)
0.4% [0.4%, 0.4%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.3% [0.1%, 0.6%] 34

Max RSS (memory usage)

Results (primary 1.1%, secondary 3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.1% [0.6%, 1.6%] 5
Regressions ❌
(secondary)
3.1% [2.1%, 4.9%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.1% [0.6%, 1.6%] 5

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.364s -> 773.892s (-0.19%)
Artifact size: 365.01 MiB -> 365.02 MiB (0.00%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 14, 2025
@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 14, 2025

cc @lcnr ^ moving it into the OwnerInfo is not feasible at present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants