-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Make std/src/num
mirror core/src/num
#137574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
rustbot has assigned @workingjubilee. Use |
☔ The latest upstream changes (presumably #138768) made this pull request unmergeable. Please resolve the merge conflicts. |
??? why didn't I see this in my queue on previous checks? |
oh wait, I see, I remember... ...uh, can we just I think I withheld comment because I was going to take a closer look to validate whether that was doable before I left the review comment, but that was an inappropriate delay and I should have left the comment, then doublechecked if I had spare energy. Sorry. |
The float modules in `std` are currently top-level but for `core`, they are nested within the `num` directory and referenced by `#[path = ...]`. For consistency, adjust `std` to use the same structure as `core`. Also change the `f16` and `f128` gates from outer attributes to inner attributes like `core` has.
7fa7a70
to
e00fa2f
Compare
Wondered about this too, I think it is because @rustbot ready |
☔ The latest upstream changes (presumably #139734) made this pull request unmergeable. Please resolve the merge conflicts. |
The float modules in
std
are currently top-level but forcore
, they are nested within thenum
directory and referenced by#[path = ...]
. For consistency, adjuststd
to use the same structure ascore
.Also change the
f16
andf128
gates from outer attributes to inner attributes likecore
has.