Ignore Self in bounds check for associated types with Self:Sized #137097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
cc @rust-lang/types @rust-lang/lang While this allows more code to compile and thus technically requires an FCP, it was just a bug that we required associated types to be mentioned in dyn trait iff the assoc ty has bounds. We filtered out assoc types before, just not the predicates that exist for them. I consider this covered by previous approvals and just an impl bug @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 16, 2025
Rollup of 5 pull requests Successful merges: - rust-lang#135797 (Import initial generated 1.85 relnotes) - rust-lang#135909 (Export kernel descriptor for amdgpu kernels) - rust-lang#136545 (nvptx64: update default alignment to match LLVM 21) - rust-lang#137092 (abi_unsupported_vector_types: say which type is the problem) - rust-lang#137097 (Ignore Self in bounds check for associated types with Self:Sized) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 16, 2025
Rollup merge of rust-lang#137097 - compiler-errors:sized-bound-self, r=oli-obk Ignore Self in bounds check for associated types with Self:Sized Fixes rust-lang#137053 This is morally a fix of rust-lang#112319, since the `Self: Sized` check was just missing here. r? oli-obk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137053
This is morally a fix of #112319, since the
Self: Sizedcheck was just missing here.r? oli-obk