Rename to {u,i}*::reinterpret_{signed,unsigned} from cast
#136489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous names did not communicate what happens to values of unsigned integers that do not fit into the target integer values. We're reinterpreting the bits as an unsigned integer, but "cast" does not say that. E.g. casting from integer to float does not reinterpret the bits, casting from `i8` to `i32` does not solely reinterpret the bits either, it sign-extends them. So "cast" doesn't tell me what happens.
rustbot
added
S-waiting-on-review
|
Blocked on the discussion that just started in #125882. |
|
@rustbot blocked |
rustbot
added
S-blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous names did not communicate what happens to values of unsigned integers that do not fit into the target integer values.
We're reinterpreting the bits as an unsigned integer, but "cast" does not say that. E.g. casting from integer to float does not reinterpret the bits, casting from
i8toi32does not solely reinterpret the bits either, it sign-extends them. So "cast" doesn't tell me what happens.CC #125882 (comment)