-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document powf and powi values that are always 1.0 #136012
base: master
Are you sure you want to change the base?
Conversation
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
This comment has been minimized.
This comment has been minimized.
Like @matthiaskrgr noted in the other PR, please merge these into one. I'm gonna leave this one open and close the rest. |
Also regarding this and those other PRs, please squash them into a single commit. A commit named "Add semicolon", "add space", etc is not adding much value to a 1 file change PR -- if you need help learning how to squash commits into one, I think any of us can point you how to do that :) |
@hkBst While we will not necessarily refuse PRs that have a remunerative motivation, we will definitely not accept degrading the quality of PRs to do so. I will accept this when you push an actual fix and it passes the standard of my review, and no sooner. |
@workingjubilee no remunerative motivation I can assure you. Apologies for any confusion arising from my use of the word "payout". EDIT: I meant "payoff" when I used "payout" (in the other comment), so I guess I was unidiomatic. Again, apologies for the confusion. |
fixes bug #90429