Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document powf and powi values that are always 1.0 #136012

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hkBst
Copy link
Contributor

@hkBst hkBst commented Jan 24, 2025

fixes bug #90429

@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 24, 2025
@hkBst hkBst changed the title Document powf and powi values that are always 1.0 Document powf and powi values that are always 1.0 (f64) Jan 24, 2025
@rust-log-analyzer

This comment has been minimized.

@compiler-errors
Copy link
Member

Like @matthiaskrgr noted in the other PR, please merge these into one. I'm gonna leave this one open and close the rest.

@compiler-errors
Copy link
Member

compiler-errors commented Jan 24, 2025

Also regarding this and those other PRs, please squash them into a single commit. A commit named "Add semicolon", "add space", etc is not adding much value to a 1 file change PR -- if you need help learning how to squash commits into one, I think any of us can point you how to do that :)

@workingjubilee
Copy link
Member

@hkBst While we will not necessarily refuse PRs that have a remunerative motivation, we will definitely not accept degrading the quality of PRs to do so. I will accept this when you push an actual fix and it passes the standard of my review, and no sooner.

@workingjubilee workingjubilee added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2025
@workingjubilee workingjubilee changed the title Document powf and powi values that are always 1.0 (f64) Document powf and powi values that are always 1.0 Jan 24, 2025
@hkBst
Copy link
Contributor Author

hkBst commented Jan 25, 2025

@workingjubilee no remunerative motivation I can assure you. Apologies for any confusion arising from my use of the word "payout".

EDIT: I meant "payoff" when I used "payout" (in the other comment), so I guess I was unidiomatic. Again, apologies for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants