tests: Port `translation` to rmake.rs #135818

jieyouxu · 2025-01-21T13:23:31Z

Part of #121876.

This PR partially supersedes #129011 and is co-authored with @Oneirical.

Summary

This PR ports tests/run-make/translation to rmake.rs. Notable changes from the Makefile version include:

We now actually fail if the rustc invocations fail... The Makefile did not have SHELL=/bin/bash -o pipefail, so all the piped rustc invocations to grep vacuously succeeded, even if the broken ftl test case actually regressed over time and ICEs on current master.
- That test case is converted to assert it fails with a FIXME backlinking to -Ztranslate-additional-ftl for a broken fluent bundle with stray interpolation argument unexpectedly ICEs #135817.
The test coverage is expanded to not ignore windows. Instead, the test now uses symlink capability detection to gate test execution.
Added some backlinks to relevant tracking issues and the initial translation infra implementation PR.

Review advice

Best reviewed commit-by-commit.

r? compiler

try-job: aarch64-apple

jieyouxu · 2025-01-21T13:25:51Z

Based on triagebot... maybe r? @davidtwco

compiler-errors · 2025-01-21T17:31:03Z

@bors r+ rollup

bors · 2025-01-21T17:31:07Z

📌 Commit 139c5ae has been approved by compiler-errors

It is now in the queue for this repository.

…mpiler-errors tests: Port `translation` to rmake.rs Part of rust-lang#121876. This PR partially supersedes rust-lang#129011 and is co-authored with `@Oneirical.` ## Summary This PR ports `tests/run-make/translation` to rmake.rs. Notable changes from the Makefile version include: - We now actually fail if the rustc invocations fail... The Makefile did not have `SHELL=/bin/bash -o pipefail`, so all the piped rustc invocations to grep vacuously succeeded, even if the broken ftl test case actually regressed over time and ICEs on current master. - That test case is converted to assert it ICEs with a FIXME backlinking to rust-lang#135817. - The test coverage is expanded to not ignore windows. Instead, the test now uses symlink capability detection to gate test execution. - Added some backlinks to relevant tracking issues and the initial translation infra implementation PR. ## Review advice Best reviewed commit-by-commit. r? compiler

Rollup of 8 pull requests Successful merges: - rust-lang#135779 (CI: free disk on linux arm runner) - rust-lang#135794 (Detect missing fields with default values and suggest `..`) - rust-lang#135814 (ci: use ghcr buildkit image) - rust-lang#135818 (tests: Port `translation` to rmake.rs) - rust-lang#135823 (make UI tests that use `--test` work on panic=abort targets) - rust-lang#135837 (Remove test panic from File::open) - rust-lang#135852 (Add `AsyncFn*` to `core` prelude) - rust-lang#135856 (Library: Finalize dyn compatibility renaming) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu · 2025-01-22T07:48:40Z

Failed in #135861 (comment)
@bors r-

jieyouxu · 2025-01-22T08:12:33Z

Slightly documented assert_exit_code and changed assert -> assert_eq to have a better panic message, added //@ needs-process to the test because wasm32-wasip1 is a great target, but no functional changes otherwise.

@bors r=compiler-errors rollup=iffy

bors · 2025-01-22T08:12:35Z

📌 Commit e142d0c has been approved by compiler-errors

It is now in the queue for this repository.

…mpiler-errors tests: Port `translation` to rmake.rs Part of rust-lang#121876. This PR partially supersedes rust-lang#129011 and is co-authored with ``@Oneirical.`` ## Summary This PR ports `tests/run-make/translation` to rmake.rs. Notable changes from the Makefile version include: - We now actually fail if the rustc invocations fail... The Makefile did not have `SHELL=/bin/bash -o pipefail`, so all the piped rustc invocations to grep vacuously succeeded, even if the broken ftl test case actually regressed over time and ICEs on current master. - That test case is converted to assert it ICEs with a FIXME backlinking to rust-lang#135817. - The test coverage is expanded to not ignore windows. Instead, the test now uses symlink capability detection to gate test execution. - Added some backlinks to relevant tracking issues and the initial translation infra implementation PR. ## Review advice Best reviewed commit-by-commit. r? compiler

Rollup of 6 pull requests Successful merges: - rust-lang#130808 (Fix linking for symbols starting with ? on i686-pc-windows-msvc) - rust-lang#133154 (Reword resolve errors caused by likely missing crate in dep tree) - rust-lang#135707 (Shorten linker output even more when `--verbose` is not present) - rust-lang#135764 (Fix tests on LLVM 20) - rust-lang#135785 (use `PassMode::Direct` for vector types on `s390x`) - rust-lang#135818 (tests: Port `translation` to rmake.rs) r? `@ghost` `@rustbot` modify labels: rollup try-job: aarch64-apple try-job: i686-mingw try-job: x86_64-gnu-llvm-19-3

…mpiler-errors tests: Port `translation` to rmake.rs Part of rust-lang#121876. This PR partially supersedes rust-lang#129011 and is co-authored with ```@Oneirical.``` ## Summary This PR ports `tests/run-make/translation` to rmake.rs. Notable changes from the Makefile version include: - We now actually fail if the rustc invocations fail... The Makefile did not have `SHELL=/bin/bash -o pipefail`, so all the piped rustc invocations to grep vacuously succeeded, even if the broken ftl test case actually regressed over time and ICEs on current master. - That test case is converted to assert it ICEs with a FIXME backlinking to rust-lang#135817. - The test coverage is expanded to not ignore windows. Instead, the test now uses symlink capability detection to gate test execution. - Added some backlinks to relevant tracking issues and the initial translation infra implementation PR. ## Review advice Best reviewed commit-by-commit. r? compiler

Rollup of 4 pull requests Successful merges: - rust-lang#135707 (Shorten linker output even more when `--verbose` is not present) - rust-lang#135764 (Fix tests on LLVM 20) - rust-lang#135785 (use `PassMode::Direct` for vector types on `s390x`) - rust-lang#135818 (tests: Port `translation` to rmake.rs) r? `@ghost` `@rustbot` modify labels: rollup try-job: aarch64-apple try-job: i686-mingw try-job: x86_64-gnu-llvm-19-3

matthiaskrgr · 2025-01-25T13:38:17Z

@bors r-
#136051 (comment) looks like its still failing

Convenience helper for `rustc --print=sysroot`.

tests: Port `translation` to rmake.rs Part of rust-lang#121876. This PR partially supersedes rust-lang#129011 and is co-authored with `@Oneirical.` ## Summary This PR ports `tests/run-make/translation` to rmake.rs. Notable changes from the Makefile version include: - We now actually fail if the rustc invocations fail... The Makefile did not have `SHELL=/bin/bash -o pipefail`, so all the piped rustc invocations to grep vacuously succeeded, even if the broken ftl test case actually regressed over time and ICEs on current master. - That test case is converted to assert it ICEs with a FIXME backlinking to rust-lang#135817. - The test coverage is expanded to not ignore windows. Instead, the test now uses symlink capability detection to gate test execution. - Added some backlinks to relevant tracking issues and the initial translation infra implementation PR. ## Review advice Best reviewed commit-by-commit. r? compiler try-job: aarch64-apple

jieyouxu · 2025-01-25T14:32:50Z

@bors try

bors · 2025-01-25T14:34:00Z

⌛ Trying commit 67357fe with merge 93fdfc4...

tests: Port `translation` to rmake.rs Part of rust-lang#121876. This PR partially supersedes rust-lang#129011 and is co-authored with `@Oneirical.` ## Summary This PR ports `tests/run-make/translation` to rmake.rs. Notable changes from the Makefile version include: - We now actually fail if the rustc invocations fail... The Makefile did not have `SHELL=/bin/bash -o pipefail`, so all the piped rustc invocations to grep vacuously succeeded, even if the broken ftl test case actually regressed over time and ICEs on current master. - That test case is converted to assert it ICEs with a FIXME backlinking to rust-lang#135817. - The test coverage is expanded to not ignore windows. Instead, the test now uses symlink capability detection to gate test execution. - Added some backlinks to relevant tracking issues and the initial translation infra implementation PR. ## Review advice Best reviewed commit-by-commit. r? compiler try-job: aarch64-apple

bors · 2025-01-25T15:46:07Z

💔 Test failed - checks-actions

Co-authored-by: Oneirical <[email protected]>

jieyouxu · 2025-01-25T16:06:13Z

tests/run-make/translation/rmake.rs

+    rustc()
+        .env("RUSTC_ICE", "0") // disable ICE dump file, not needed
+        .input("test.rs")
+        .arg("-Ztranslate-additional-ftl=broken.ftl")
+        .run_fail();


I'm not going to assert that this ICEs because it somehow doesn't ICE on aarch64-apple-darwin, instead I'm just going to assert that it fails.

jieyouxu · 2025-01-25T16:07:07Z

@bors r=compiler-errors rollup=never

bors · 2025-01-25T16:07:09Z

📌 Commit 3385166 has been approved by compiler-errors

It is now in the queue for this repository.

rustbot assigned petrochenkov Jan 21, 2025

jieyouxu added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Jan 21, 2025

This comment was marked as off-topic.

Sign in to view

rustbot assigned davidtwco and unassigned petrochenkov Jan 21, 2025

This was referenced Jan 21, 2025

Migrate libs-through-symlinks and translation run-make tests to rmake #129011

Closed

Tracking Issue for porting run-make tests to use Rust #121876

Open

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2025

jieyouxu assigned compiler-errors and unassigned davidtwco Jan 22, 2025

jieyouxu mentioned this pull request Jan 22, 2025

Rollup of 8 pull requests #135861

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 22, 2025

jieyouxu force-pushed the migrate-translation branch 2 times, most recently from 80be239 to e142d0c Compare January 22, 2025 08:11

matthiaskrgr mentioned this pull request Jan 25, 2025

Rollup of 6 pull requests #136049

Closed

matthiaskrgr mentioned this pull request Jan 25, 2025

Rollup of 4 pull requests #136051

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 25, 2025

jieyouxu added 2 commits January 25, 2025 22:11

run-make-support: add sysroot helper

9a4a2f1

Convenience helper for `rustc --print=sysroot`.

run-make-support: improve docs for assert_exit_code

bd2a222

jieyouxu force-pushed the migrate-translation branch from 388a52f to 4e38606 Compare January 25, 2025 14:18

This comment was marked as resolved.

Sign in to view

This comment has been minimized.

Sign in to view

jieyouxu force-pushed the migrate-translation branch from 4e38606 to 67357fe Compare January 25, 2025 14:31

This comment has been minimized.

Sign in to view

tests: port translation to rmake.rs

3385166

Co-authored-by: Oneirical <[email protected]>

jieyouxu force-pushed the migrate-translation branch from 67357fe to 3385166 Compare January 25, 2025 16:05

jieyouxu commented Jan 25, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: Port `translation` to rmake.rs #135818

tests: Port `translation` to rmake.rs #135818

jieyouxu commented Jan 21, 2025 •

edited

Loading

This comment was marked as off-topic.

This comment was marked as off-topic.

jieyouxu commented Jan 21, 2025

compiler-errors commented Jan 21, 2025

bors commented Jan 21, 2025

jieyouxu commented Jan 22, 2025

jieyouxu commented Jan 22, 2025

bors commented Jan 22, 2025

matthiaskrgr commented Jan 25, 2025

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment has been minimized.

jieyouxu commented Jan 25, 2025

bors commented Jan 25, 2025

This comment has been minimized.

bors commented Jan 25, 2025

jieyouxu Jan 25, 2025

jieyouxu commented Jan 25, 2025

bors commented Jan 25, 2025

tests: Port translation to rmake.rs #135818

Are you sure you want to change the base?

tests: Port translation to rmake.rs #135818

Conversation

jieyouxu commented Jan 21, 2025 • edited Loading

Summary

Review advice

This comment was marked as off-topic.

This comment was marked as off-topic.

jieyouxu commented Jan 21, 2025

compiler-errors commented Jan 21, 2025

bors commented Jan 21, 2025

jieyouxu commented Jan 22, 2025

jieyouxu commented Jan 22, 2025

bors commented Jan 22, 2025

matthiaskrgr commented Jan 25, 2025

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment has been minimized.

jieyouxu commented Jan 25, 2025

bors commented Jan 25, 2025

This comment has been minimized.

bors commented Jan 25, 2025

jieyouxu Jan 25, 2025

Choose a reason for hiding this comment

jieyouxu commented Jan 25, 2025

bors commented Jan 25, 2025

tests: Port `translation` to rmake.rs #135818

tests: Port `translation` to rmake.rs #135818

jieyouxu commented Jan 21, 2025 •

edited

Loading