-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: use import stability marker in display #135352
Conversation
This comment has been minimized.
This comment has been minimized.
1c83f04
to
ce215c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! r=me after addressing the comment on the test
This comment has been minimized.
This comment has been minimized.
ce215c0
to
74aca3f
Compare
This comment has been minimized.
This comment has been minimized.
74aca3f
to
916cfbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. I do wonder whether there are cases opposite from what this fixes -- i.e. where the re-export stability is wrong and the original item is what we should use. I tested locally and found that #[unstable]
on a re-export of a stable item is ignored by rustc.
But in the particular case this PR addresses, I think the new behavior overall makes more sense, so let's merge it.
@bors r+ rollup |
☀️ Test successful - checks-actions |
Finished benchmarking commit (a2016aa): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -3.0%, secondary -1.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 763.719s -> 764.824s (0.14%) |
Fixes #135078