centralize build stamp logic

[onur-ozkan]

This PR brings all the stamp file handling into one place inside build_stamp module, which takes care of everything related to build stamps. By doing this, we cut down on duplicated code and types and keep the codebase easier to maintain and more consistent.

Main goals are:

• Make stamp handling stricter so we don't have to pass Paths around and manually join on arbitrary directories
• Keep all stamp-related logic in one place
• Make it easier to test and debug
• Avoid duplication
• Keep things simple and well-documented

Resolves #134962

[rustbot]

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

[rustbot]

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

[jieyouxu]

(This would close #134962)

[onur-ozkan]

(This would close #134962)

Funny that I haven't even seen it...

[rustbot]

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

[jieyouxu]

I'll review this tmrw, I wanted to do some more manual local testing just in case. I had a brief glance at the changes, and I must say this is much easier to follow. So thank you for cleaning this up!

[onur-ozkan]

@rustbot ready

[rustbot]

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

[jieyouxu]

Nooooooooooooooooo I don't want to rebase this PR.....

I would probably just squash the bootstrap bits in one commit and r-d-g bits in another commit, lol

[onur-ozkan]

@rustbot ready

[onur-ozkan]

Nooooooooooooooooo I don't want to rebase this PR.....

I would probably just squash the bootstrap bits in one commit and r-d-g bits in another commit, lol

Some commits (like b03fba7) shouldn't exist by their own but it's just too painful to squash them with related ones when you have too many commits..

[jieyouxu]

Some commits (like b03fba7) shouldn't exist by their own but it's just too painful to squash them with related ones when you have too many commits..

I mean like squash all the bootstrap bits into one commit lol.

[onur-ozkan]

Some commits (like b03fba7) shouldn't exist by their own but it's just too painful to squash them with related ones when you have too many commits..

I mean like squash all the bootstrap bits into one commit lol.

That's even worse lol

[jieyouxu]

Thanks, you can r=me after PR CI is green.

[onur-ozkan]

@bors r=jieyouxu rollup=never

[bors]

📌 Commit 2a4bcf5 has been approved by jieyouxu

It is now in the queue for this repository.

[bors]

⌛ Testing commit 2a4bcf5 with merge 627513a...

[bors]

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 627513a to master...

[rust-timer]

Finished benchmarking commit (627513a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[3.0%, 3.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 763.652s -> 763.304s (-0.05%)
Artifact size: 326.10 MiB -> 326.03 MiB (-0.02%)