-
Notifications
You must be signed in to change notification settings - Fork 13.5k
setup typos check in CI #134006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
setup typos check in CI #134006
Changes from all commits
7e9e472
ebbb7e4
c047628
c2e7951
5476da0
e926f3d
d38d773
1687137
e706f8c
b609f61
1dd123c
2b0c4da
b36a2e0
7c85b94
44577ac
507f777
92014e7
e6bd905
7fc0a9c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# This workflow runs spellcheck job | ||
|
||
name: Spellcheck | ||
on: | ||
pull_request: | ||
branches: | ||
- "**" | ||
|
||
jobs: | ||
spellcheck: | ||
name: run spellchecker | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout the source code | ||
uses: actions/checkout@v4 | ||
|
||
- name: check typos | ||
# sync version with src/tools/tidy/src/ext_tool_checks.rs | ||
uses: crate-ci/[email protected] | ||
with: | ||
# sync target files with src/tools/tidy/src/ext_tool_checks.rs | ||
files: ./compiler ./library ./src/bootstrap ./src/librustdoc | ||
config: ./typos.toml |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,6 +36,7 @@ path = [ | |
"rustfmt.toml", | ||
"rust-bors.toml", | ||
"triagebot.toml", | ||
"typos.toml", | ||
"x", | ||
"x.ps1", | ||
"x.py", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -572,7 +572,7 @@ where | |
Right((local, offset, locals_addr, layout)) => { | ||
if offset.is_some() { | ||
// This has been projected to a part of this local, or had the type changed. | ||
// FIMXE: there are cases where we could still avoid allocating an mplace. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. lol |
||
// FIXME: there are cases where we could still avoid allocating an mplace. | ||
Left(place.force_mplace(self)?) | ||
} else { | ||
debug_assert_eq!(locals_addr, self.frame().locals_addr()); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -439,7 +439,7 @@ impl<'hir> ConstArg<'hir, AmbigArg> { | |
} | ||
|
||
impl<'hir> ConstArg<'hir> { | ||
/// Converts a `ConstArg` in an unambigous position to one in an ambiguous position. This is | ||
/// Converts a `ConstArg` in an unambiguous position to one in an ambiguous position. This is | ||
/// fallible as the [`ConstArgKind::Infer`] variant is not present in ambiguous positions. | ||
/// | ||
/// Functions accepting ambiguous consts will not handle the [`ConstArgKind::Infer`] variant, if | ||
|
@@ -508,7 +508,7 @@ pub enum GenericArg<'hir> { | |
Lifetime(&'hir Lifetime), | ||
Type(&'hir Ty<'hir, AmbigArg>), | ||
Const(&'hir ConstArg<'hir, AmbigArg>), | ||
/// Inference variables in [`GenericArg`] are always represnted by | ||
/// Inference variables in [`GenericArg`] are always represented by | ||
/// `GenericArg::Infer` instead of the `Infer` variants on [`TyKind`] and | ||
/// [`ConstArgKind`] as it is not clear until hir ty lowering whether a | ||
/// `_` argument is a type or const argument. | ||
|
@@ -3323,7 +3323,7 @@ impl<'hir> Ty<'hir, AmbigArg> { | |
} | ||
|
||
impl<'hir> Ty<'hir> { | ||
/// Converts a `Ty` in an unambigous position to one in an ambiguous position. This is | ||
/// Converts a `Ty` in an unambiguous position to one in an ambiguous position. This is | ||
/// fallible as the [`TyKind::Infer`] variant is not present in ambiguous positions. | ||
/// | ||
/// Functions accepting ambiguous types will not handle the [`TyKind::Infer`] variant, if | ||
|
@@ -4224,7 +4224,7 @@ impl fmt::Display for Constness { | |
} | ||
} | ||
|
||
/// The actualy safety specified in syntax. We may treat | ||
/// The actually safety specified in syntax. We may treat | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this should be "actual"? That makes more sense than "actually", though I'm not certain. @oli-obk: git tells me you wrote this comment, can you confirm? |
||
/// its safety different within the type system to create a | ||
/// "sound by default" system that needs checking this enum | ||
/// explicitly to allow unsafe operations. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two locations in that file that need to be synced, please mention that.