Implement RFC3695 Allow boolean literals as cfg predicates #131034

Urgau · 2024-09-29T20:11:44Z

This PR implements rust-lang/rfcs#3695: allow boolean literals as cfg predicates, i.e. cfg(true) and cfg(false).

r? @nnethercote (or anyone with parser knowledge)
cc @clubby789

compiler/rustc_feature/src/unstable.rs

rustbot · 2024-09-29T21:40:38Z

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

compiler/rustc_builtin_macros/src/cfg.rs

tests/ui/macros/cfg.stderr

compiler/rustc_trait_selection/src/error_reporting/traits/on_unimplemented.rs

tests/ui/cfg/true-false.rs

src/doc/unstable-book/src/language-features/cfg-boolean-literals.md

compiler/rustc_parse/src/parser/attr.rs

nnethercote · 2024-10-01T01:15:49Z

Basically looks good, a few comments above.

nnethercote · 2024-10-01T10:39:05Z

Thanks!

@bors r+

bors · 2024-10-01T10:39:08Z

📌 Commit f9fc1fb has been approved by nnethercote

It is now in the queue for this repository.

Urgau · 2024-10-04T08:23:23Z

Added the tracking issue. CI passes. Let's go.

@bors r=@nnethercote

bors · 2024-10-04T08:23:27Z

📌 Commit a3ffa1e has been approved by nnethercote

It is now in the queue for this repository.

Implement RFC3695 Allow boolean literals as cfg predicates This PR implements rust-lang/rfcs#3695: allow boolean literals as cfg predicates, i.e. `cfg(true)` and `cfg(false)`. r? `@nnethercote` *(or anyone with parser knowledge)* cc `@clubby789`

bors · 2024-10-04T10:39:05Z

⌛ Testing commit a3ffa1e with merge 99f3f45...

rust-log-analyzer · 2024-10-04T12:44:14Z

The job dist-x86_64-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[2024-10-04T11:33:09Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-10-04T11:33:09Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Check, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-10-04T11:33:09Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpZnnokj#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln"
[2024-10-04T11:33:15Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
[2024-10-04T11:33:15Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpZnnokj#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpZnnokj\\incremental-state"
[2024-10-04T11:33:21Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrUnchanged), patch=None, backend=Llvm, phase=benchmark
[2024-10-04T11:33:21Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpZnnokj#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpZnnokj\\incremental-state"
[2024-10-04T11:33:22Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-10-04T11:33:22Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Debug, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-10-04T11:33:22Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmp0O3thZ#[email protected]" "--" "--wrap-rustc-with" "Eprintln"
[2024-10-04T11:33:27Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
---
   Compiling build_helper v0.1.0 (C:\a\rust\rust\src\tools\build_helper)
   Compiling xz2 v0.1.7
error: linking with `link.exe` failed: exit code: 1104
  |
  = note: "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.41.34120\\bin\\HostX64\\x64\\link.exe" "/NOLOGO" "C:\\a\\_temp\\msys64\\tmp\\rustcONKqp2\\symbols.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.05llmrdwn03a0b77dnz5udzep.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.0e2ytppeejv4ymfgdma5a4xjs.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.0f27pcg32lx3zky0bpcocnbe2.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.16wyqlb65semkmor3cw0ypecf.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.1ea2c9xo9b8utl7agdqa3t2sa.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.1efp9dbs9sp7nq8clzuhn6mgs.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.1fmu7n5ekdth3xaoqg810x488.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.1iqvu1rtf52b4klx5xdg0jtbg.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.1o067xn61xh4gw7d7a210pbnd.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.1qnv7fgvs7qe2a71grs68bjg6.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.1tkfl2gfpusibpdgohqs4jjjf.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.26ruziq30etzj828zfsc9812y.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.27juez97i64v85uzbf5qpxd5o.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.2806jk4hceyqhdyv1ub95bygg.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.2apos5gtqme2vhfj5cb1pjrps.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.2lorx6jhbnpwswcd1p253mhxt.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.2rqvzwai8qovfwckfi12de4vl.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.2vf1hwdde99zxni7i4ge9xb22.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.34xmkgbdh92jehcsd80h49q8q.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.36grs4azn9fnkmgynz3bznku2.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.37qm62x4x7vyrbx63dteh9cnm.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.3fw6lkc0hqgsin4yhwpwkue5h.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.3oxwzvqp2po13rxb6b5w0cg1f.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.4a75juhfrf2cjvc5ol31c57fh.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.4k4gcp4pqgk8xjp152f3a486x.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.4nbjgzw5h5xkw36r8d3eru49p.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.4zjdhug8wdfyskjhtoqottu6m.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.520uqq23avn2hrmgrjypdpfk8.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.55xydayy8nzag1k5zsvg020o2.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.577g1b0040vg2nnbbz8o7woim.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.585haoxnj7gdnb25bigs6iqeb.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.5elaz5do66ol0hswiklejs3yb.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.5r2a30p6mn7hefhkdsvlchye0.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.5y7xn8m8kvlr8mzj18g7ckh82.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.5ztt9edkf9m9koyav4cnlvywz.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.64yrgdaqyrpu3s34jh8t2elnd.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.67x3l54qwhaujbyyougl9cwyq.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.6f2aimotdvw5thq459bbdu4a6.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.6gkkhdqgfwvl0dzq6eplbemri.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.783kzpv0aruk2421knz5b2hbh.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.7edk2pww7mnqrwnr8jmbe17y6.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.7ezb0fjb2kfp64gkfjbe2d4qk.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.7g7qq75ih3lfz7e5y838vr7ig.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.7gqat23ik6zgc2aysthrr4mu9.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.7icvx9u8cu3c6ux33pkcq3ba2.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.7iuzjdh1p5pgniydmkhs4i8xn.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.7nxda3hzzq0vo6zezb4uf1cnz.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.7o6d2mtxp4te6iw9xayv06iy1.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.7qx7kvspfizkv4ppn2o57h2ky.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.8sou44k4jofzvifaflsr73fjg.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.8t2wj6xuh3dz2kx8g1g91wt3h.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.8xoh7ngxewb8tbtm231ga7g9p.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.9mkzpgratsfjocnwq284dlyjl.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.9ndpjm98fvke18ku9yp19cpu6.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.9r3tg8hv784pto5th364q0p9p.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.9vk671x2lnquz6y71ckfya3k1.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.9vmt89pxtyy3d18c35ozo9csc.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.9vx5jitmbw0v6khc8ssrg5eyh.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.a218b5m5j3jmyjuqv8tkbpmlm.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.a9arfzzc5a41tioixm7q4bh4f.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.aehrdhvj2uljndazm1rzbpaw5.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.ag4ycagnpobp82dpd8a1qs4dk.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.ah5xx7s8iwlbkohi357bjcwuo.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.aiue86pew52ajx6nktjg9n0be.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.aqmn41r82rxx83357vxp5m00i.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.as2sqz9qngsvjxlytm8yek2sv.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.b3aiota2pfwcj8bewt9lnhrxz.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.bg4e3h9um3jlcolexebf3kj66.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.bi3qradr5nct62lzfevkan4yj.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.bm1btxzb021nni42k7aoknj26.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.bmiz5qfmdvhd4q1bf4z5t3ik2.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.c2mi2xgks8mez9yh6pw42zkna.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.c31ynzo8rfyiskb2uvuqhyo7e.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.c3amb3prfjt0pf9126i3jnq99.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.c4aoprkcfcvf8ykglzoyfdcv5.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.c69d9hwntzmek8k8tb5p2wy2k.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.c69iss6xxp0z179wwuxshia6l.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.c8tcaoo2t686f3ngsh5w8kjqh.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.cg70csaqtenve9jbb8gp7t4kk.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.cg7dounysbxdpark5cr4e1ond.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.cy866b5kqolmbvxmtbnqu3ngq.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.czs3x3lj6tod0cqpata87732r.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.d7yvrdumj0gcpt0rok8wpn07d.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.d9x3zx39y3n94reexzfvxuy9u.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.dax4x42iyllgm1p17e3ie0s7a.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.dfjsim0fx3xf3svitje2difso.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.dj9xyyaa1on09usd6kn2asy0e.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.dk0azk69q5xge22ujbd9yul9m.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.dv5umsvy9emmgfi1mnjt48xny.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.e0y299ozgnjdv3c7p30znkx9f.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.e2x7j8k3rmoazvd99g6ke504b.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.e5388pdg67fmtb4b40h4z8dk6.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.e5pc84u2mcqr0be4zt1at7q04.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.e66eozb39pze4qfz8n1e4cfp2.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.eq1cx8sig1v7taaeooioi1szu.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.evq7abuh5w4xi6p00qpkjes0n.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.dsjoch993ny0us8l97kptvyw2.rcgu.o" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\libwindows-a1477e378b544e1f.rlib" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\libwindows_core-ef58cf45b94d71ff.rlib" "C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\libwindows_targets-b6996b8fc6479fdb.rlib" "C:\\a\\rust\\rust\\build\\unpacked-dist\\rustc-nightly-x86_64-pc-windows-msvc\\rustc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libstd-35ab10bf423e038e.rlib" "C:\\a\\rust\\rust\\build\\unpacked-dist\\rustc-nightly-x86_64-pc-windows-msvc\\rustc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libpanic_unwind-027a47526096953f.rlib" "C:\\a\\rust\\rust\\build\\unpacked-dist\\rustc-nightly-x86_64-pc-windows-msvc\\rustc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libmemchr-a316bc7e4f9b1a11.rlib" "C:\\a\\rust\\rust\\build\\unpacked-dist\\rustc-nightly-x86_64-pc-windows-msvc\\rustc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libwindows_targets-650a9189f256d76e.rlib" "C:\\a\\rust\\rust\\build\\unpacked-dist\\rustc-nightly-x86_64-pc-windows-msvc\\rustc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_demangle-b9458f293a7d71b6.rlib" "C:\\a\\rust\\rust\\build\\unpacked-dist\\rustc-nightly-x86_64-pc-windows-msvc\\rustc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libstd_detect-68fd1c1a06264e1c.rlib" "C:\\a\\rust\\rust\\build\\unpacked-dist\\rustc-nightly-x86_64-pc-windows-msvc\\rustc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libhashbrown-f52352a23249a6ef.rlib" "C:\\a\\rust\\rust\\build\\unpacked-dist\\rustc-nightly-x86_64-pc-windows-msvc\\rustc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_std_workspace_alloc-cb0b0d612da96332.rlib" "C:\\a\\rust\\rust\\build\\unpacked-dist\\rustc-nightly-x86_64-pc-windows-msvc\\rustc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libunwind-ba71eedaf2805b51.rlib" "C:\\a\\rust\\rust\\build\\unpacked-dist\\rustc-nightly-x86_64-pc-windows-msvc\\rustc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcfg_if-12ecda8b10447785.rlib" "C:\\a\\rust\\rust\\build\\unpacked-dist\\rustc-nightly-x86_64-pc-windows-msvc\\rustc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liballoc-799f2200e3aa8ae9.rlib" "C:\\a\\rust\\rust\\build\\unpacked-dist\\rustc-nightly-x86_64-pc-windows-msvc\\rustc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_std_workspace_core-5a536bba43fbe272.rlib" "C:\\a\\rust\\rust\\build\\unpacked-dist\\rustc-nightly-x86_64-pc-windows-msvc\\rustc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcore-45b7a05b67ddb8c6.rlib" "C:\\a\\rust\\rust\\build\\unpacked-dist\\rustc-nightly-x86_64-pc-windows-msvc\\rustc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcompiler_builtins-351f7328e42d8cf6.rlib" "C:\\Users\\runneradmin\\.cargo\\registry\\src\\index.crates.io-6f17d22bba15001f\\windows_x86_64_msvc-0.52.6\\lib\\windows.0.52.0.lib" "C:\\Users\\runneradmin\\.cargo\\registry\\src\\index.crates.io-6f17d22bba15001f\\windows_x86_64_msvc-0.52.6\\lib\\windows.0.52.0.lib" "kernel32.lib" "kernel32.lib" "advapi32.lib" "ntdll.lib" "userenv.lib" "ws2_32.lib" "dbghelp.lib" "/defaultlib:msvcrt" "/NXCOMPAT" "/LIBPATH:C:\\Users\\runneradmin\\.cargo\\registry\\src\\index.crates.io-6f17d22bba15001f\\windows_x86_64_msvc-0.52.6\\lib" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.41.34120\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\bootstrap\\debug\\build\\lzma-sys-e49218993f0fc347\\out" "/OUT:C:\\a\\rust\\rust\\build\\bootstrap\\debug\\deps\\rustc.exe" "/OPT:REF,NOICF" "/DEBUG" "/PDBALTPATH:%_PDB%" "/NATVIS:C:\\a\\rust\\rust\\build\\unpacked-dist\\rustc-nightly-x86_64-pc-windows-msvc\\rustc\\lib\\rustlib\\etc\\intrinsic.natvis" "/NATVIS:C:\\a\\rust\\rust\\build\\unpacked-dist\\rustc-nightly-x86_64-pc-windows-msvc\\rustc\\lib\\rustlib\\etc\\liballoc.natvis" "/NATVIS:C:\\a\\rust\\rust\\build\\unpacked-dist\\rustc-nightly-x86_64-pc-windows-msvc\\rustc\\lib\\rustlib\\etc\\libcore.natvis" "/NATVIS:C:\\a\\rust\\rust\\build\\unpacked-dist\\rustc-nightly-x86_64-pc-windows-msvc\\rustc\\lib\\rustlib\\etc\\libstd.natvis"
  = note: LINK : fatal error LNK1104: cannot open file 'C:\a\rust\rust\build\bootstrap\debug\deps\rustc.exe'␍

error: could not compile `bootstrap` (bin "rustc") due to 1 previous error
warning: build failed, waiting for other jobs to finish...
failed to run: C:/a/rust/rust/build/unpacked-dist/cargo-nightly-x86_64-pc-windows-msvc/cargo/bin/cargo.exe build --manifest-path C:\a\rust\rust\src/bootstrap/Cargo.toml

bors · 2024-10-04T12:44:49Z

💔 Test failed - checks-actions

Urgau · 2024-10-04T12:49:31Z

= note: LINK : fatal error LNK1104: cannot open file 'C:\a\rust\rust\build\bootstrap\debug\deps\rustc.exe'

@bors retry fatal error LNK1104 #127883

…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#131034 (Implement RFC3695 Allow boolean literals as cfg predicates) - rust-lang#131202 (Use wide pointers consistenly across the compiler) - rust-lang#131230 (Enable `--no-sandbox` option by default for rustdoc GUI tests) - rust-lang#131232 (Week off of reviews to focus on docs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#131034 - Urgau:cfg-true-false, r=nnethercote Implement RFC3695 Allow boolean literals as cfg predicates This PR implements rust-lang/rfcs#3695: allow boolean literals as cfg predicates, i.e. `cfg(true)` and `cfg(false)`. r? `@nnethercote` *(or anyone with parser knowledge)* cc `@clubby789`

…t, r=davidtwco,Urgau,traviscross Stabilize `cfg_boolean_literals` Closes rust-lang#131204 `@rustbot` labels +T-lang +I-lang-nominated This will end up conflicting with the test in rust-lang#138293 so whichever doesn't land first will need updating -- # Stabilization Report ## General design ### What is the RFC for this feature and what changes have occurred to the user-facing design since the RFC was finalized? [RFC 3695](rust-lang/rfcs#3695), none. ### What behavior are we committing to that has been controversial? Summarize the major arguments pro/con. None ### Are there extensions to this feature that remain unstable? How do we know that we are not accidentally committing to those? None ## Has a call-for-testing period been conducted? If so, what feedback was received? Yes; only positive feedback was received. ## Implementation quality ### Summarize the major parts of the implementation and provide links into the code (or to PRs) Implemented in [rust-lang#131034](rust-lang#131034). ### Summarize existing test coverage of this feature - [Basic usage, including `#[cfg()]`, `cfg!()` and `#[cfg_attr()]`](https://github.com/rust-lang/rust/blob/6d71251cf9e40326461f90f8ff9a7024706aea87/tests/ui/cfg/true-false.rs) - [`--cfg=true/false` on the command line being accessible via `r#true/r#false`](https://github.com/rust-lang/rust/blob/6d71251cf9e40326461f90f8ff9a7024706aea87/tests/ui/cfg/raw-true-false.rs) - [Interaction with the unstable `#[doc(cfg(..))]` feature](https://github.com/rust-lang/rust/tree/6d71251/tests/rustdoc-ui/cfg-boolean-literal.rs) - [Denying `--check-cfg=cfg(true/false)`](https://github.com/rust-lang/rust/tree/6d71251/tests/ui/check-cfg/invalid-arguments.rs) - Ensuring `--cfg false` on the command line doesn't change the meaning of `cfg(false)`: `tests/ui/cfg/cmdline-false.rs` - Ensuring both `cfg(true)` and `cfg(false)` on the same item result in it being disabled: `tests/ui/cfg/both-true-false.rs` ### What outstanding bugs in the issue tracker involve this feature? Are they stabilization-blocking? The above mentioned issue; it should not block as it interacts with another unstable feature. ### What FIXMEs are still in the code for that feature and why is it ok to leave them there? None ### Summarize contributors to the feature by name for recognition and assuredness that people involved in the feature agree with stabilization - `@clubby789` (RFC) - `@Urgau` (Implementation in rustc) ### Which tools need to be adjusted to support this feature. Has this work been done? `rustdoc`'s unstable`#[doc(cfg(..)]` has been updated to respect it. `cargo` has been updated with a forward compatibility lint to enable supporting it in cargo once stabilized. ## Type system and execution rules ### What updates are needed to the reference/specification? (link to PRs when they exist) A few lines to be added to the reference for configuration predicates, specified in the RFC.

Rollup merge of rust-lang#138632 - clubby789:stabilize-cfg-boolean-lit, r=davidtwco,Urgau,traviscross Stabilize `cfg_boolean_literals` Closes rust-lang#131204 `@rustbot` labels +T-lang +I-lang-nominated This will end up conflicting with the test in rust-lang#138293 so whichever doesn't land first will need updating -- # Stabilization Report ## General design ### What is the RFC for this feature and what changes have occurred to the user-facing design since the RFC was finalized? [RFC 3695](rust-lang/rfcs#3695), none. ### What behavior are we committing to that has been controversial? Summarize the major arguments pro/con. None ### Are there extensions to this feature that remain unstable? How do we know that we are not accidentally committing to those? None ## Has a call-for-testing period been conducted? If so, what feedback was received? Yes; only positive feedback was received. ## Implementation quality ### Summarize the major parts of the implementation and provide links into the code (or to PRs) Implemented in [rust-lang#131034](rust-lang#131034). ### Summarize existing test coverage of this feature - [Basic usage, including `#[cfg()]`, `cfg!()` and `#[cfg_attr()]`](https://github.com/rust-lang/rust/blob/6d71251cf9e40326461f90f8ff9a7024706aea87/tests/ui/cfg/true-false.rs) - [`--cfg=true/false` on the command line being accessible via `r#true/r#false`](https://github.com/rust-lang/rust/blob/6d71251cf9e40326461f90f8ff9a7024706aea87/tests/ui/cfg/raw-true-false.rs) - [Interaction with the unstable `#[doc(cfg(..))]` feature](https://github.com/rust-lang/rust/tree/6d71251/tests/rustdoc-ui/cfg-boolean-literal.rs) - [Denying `--check-cfg=cfg(true/false)`](https://github.com/rust-lang/rust/tree/6d71251/tests/ui/check-cfg/invalid-arguments.rs) - Ensuring `--cfg false` on the command line doesn't change the meaning of `cfg(false)`: `tests/ui/cfg/cmdline-false.rs` - Ensuring both `cfg(true)` and `cfg(false)` on the same item result in it being disabled: `tests/ui/cfg/both-true-false.rs` ### What outstanding bugs in the issue tracker involve this feature? Are they stabilization-blocking? The above mentioned issue; it should not block as it interacts with another unstable feature. ### What FIXMEs are still in the code for that feature and why is it ok to leave them there? None ### Summarize contributors to the feature by name for recognition and assuredness that people involved in the feature agree with stabilization - `@clubby789` (RFC) - `@Urgau` (Implementation in rustc) ### Which tools need to be adjusted to support this feature. Has this work been done? `rustdoc`'s unstable`#[doc(cfg(..)]` has been updated to respect it. `cargo` has been updated with a forward compatibility lint to enable supporting it in cargo once stabilized. ## Type system and execution rules ### What updates are needed to the reference/specification? (link to PRs when they exist) A few lines to be added to the reference for configuration predicates, specified in the RFC.

…dtwco,Urgau,traviscross Stabilize `cfg_boolean_literals` Closes #131204 `@rustbot` labels +T-lang +I-lang-nominated This will end up conflicting with the test in #138293 so whichever doesn't land first will need updating -- # Stabilization Report ## General design ### What is the RFC for this feature and what changes have occurred to the user-facing design since the RFC was finalized? [RFC 3695](rust-lang/rfcs#3695), none. ### What behavior are we committing to that has been controversial? Summarize the major arguments pro/con. None ### Are there extensions to this feature that remain unstable? How do we know that we are not accidentally committing to those? None ## Has a call-for-testing period been conducted? If so, what feedback was received? Yes; only positive feedback was received. ## Implementation quality ### Summarize the major parts of the implementation and provide links into the code (or to PRs) Implemented in [#131034](rust-lang/rust#131034). ### Summarize existing test coverage of this feature - [Basic usage, including `#[cfg()]`, `cfg!()` and `#[cfg_attr()]`](https://github.com/rust-lang/rust/blob/6d71251cf9e40326461f90f8ff9a7024706aea87/tests/ui/cfg/true-false.rs) - [`--cfg=true/false` on the command line being accessible via `r#true/r#false`](https://github.com/rust-lang/rust/blob/6d71251cf9e40326461f90f8ff9a7024706aea87/tests/ui/cfg/raw-true-false.rs) - [Interaction with the unstable `#[doc(cfg(..))]` feature](https://github.com/rust-lang/rust/tree/6d71251/tests/rustdoc-ui/cfg-boolean-literal.rs) - [Denying `--check-cfg=cfg(true/false)`](https://github.com/rust-lang/rust/tree/6d71251/tests/ui/check-cfg/invalid-arguments.rs) - Ensuring `--cfg false` on the command line doesn't change the meaning of `cfg(false)`: `tests/ui/cfg/cmdline-false.rs` - Ensuring both `cfg(true)` and `cfg(false)` on the same item result in it being disabled: `tests/ui/cfg/both-true-false.rs` ### What outstanding bugs in the issue tracker involve this feature? Are they stabilization-blocking? The above mentioned issue; it should not block as it interacts with another unstable feature. ### What FIXMEs are still in the code for that feature and why is it ok to leave them there? None ### Summarize contributors to the feature by name for recognition and assuredness that people involved in the feature agree with stabilization - `@clubby789` (RFC) - `@Urgau` (Implementation in rustc) ### Which tools need to be adjusted to support this feature. Has this work been done? `rustdoc`'s unstable`#[doc(cfg(..)]` has been updated to respect it. `cargo` has been updated with a forward compatibility lint to enable supporting it in cargo once stabilized. ## Type system and execution rules ### What updates are needed to the reference/specification? (link to PRs when they exist) A few lines to be added to the reference for configuration predicates, specified in the RFC.

rustbot assigned nnethercote Sep 29, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 29, 2024

Urgau commented Sep 29, 2024

View reviewed changes

compiler/rustc_feature/src/unstable.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Urgau force-pushed the cfg-true-false branch from bcc6f65 to 85e872a Compare September 30, 2024 07:29

jieyouxu reviewed Sep 30, 2024

View reviewed changes

compiler/rustc_builtin_macros/src/cfg.rs Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

Urgau force-pushed the cfg-true-false branch 2 times, most recently from c17dd7b to 10dbf46 Compare September 30, 2024 18:34

rust-lang deleted a comment from rust-log-analyzer Sep 30, 2024

This comment has been minimized.

Sign in to view

Urgau force-pushed the cfg-true-false branch from 10dbf46 to 3db7704 Compare September 30, 2024 20:00