Rollup of 4 pull requests #123557
Merged
Rollup of 4 pull requests #123557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iling to build the C lib
extern-so: give the version script a better name; show errors from failing to build the C lib
No functional change in this commit
speed up Windows CI The many-seeds test is taking 15 minutes. Let's just run that only once instead of many times on Windows. Also refactor the CI script to make the caller control which tests are being run.
looks like the M1 runners don't like it when the cache was created on x86 also reorder the lines to be more semantically grouped
experiment with macOS M1 runners Try running our macOS CI on the new free M1 runners. This would mean that our 3 jobs run 3 different OSes and 3 different host CPU architectures. :)
update josh version and guidance
Automatic Rustup
shims/unix: split general FD management from FS access `fd.rs` was a mix of general file descriptor infrastructure and file system access. Split those things up properly. Also add a `socket.rs` file where support for sockets can go eventually. For now it just contains the socketpair stub.
…th their FD types
…r=RalfJung shims/linux: move epoll and eventfd into their own respective files Also put the FD types into those files; they can then even be made private there.
eventfd: fix flag check and note a FIXME
Automatic Rustup
make 'missing extern static' error consistent with missing shim What's relevant is mostly the link name of the external symbol, not its Rust path.
This ensures that the tests actually test what they are meant to test rather than exitting immediately with an error that -Zquery-dep-graph has to be passed.
…Simulacrum remove miri-test-libstd hacks that are no longer needed In rust-lang#123317 we developed a different approach to testing the standard library in Miri, and with rust-lang/miri-test-libstd#56 the out-of-tree miri-test-libstd has been switched to that approach. That makes these hacks here no longer necessary.
…acrum Add missing -Zquery-dep-graph to the spike-neg incr comp tests This ensures that the tests actually test what they are meant to test rather than exitting immediately with an error that -Zquery-dep-graph has to be passed.
Miri subtree update r? `@ghost`
…lt-color, r=notriddle Simplify/cleanup `search-result-color.goml` Greatly shorten code of `search-result-color.goml` GUI test. I split the changes into smaller commits to allow to more easily see what changed. r? `@notriddle`
rustbot
added
S-waiting-on-review
|
@bors r+ p=4 rollup=never |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 773fb88e13 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (aa1c459): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 668.041s -> 670.181s (0.32%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
search-result-color.goml#123554 (Simplify/cleanupsearch-result-color.goml)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup