Skip to content

Expand doc comment on MIR validation. #115942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Expand doc comment on MIR validation. #115942

wants to merge 1 commit into from

Conversation

cjgillot
Copy link
Contributor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 18, 2023
RalfJung
RalfJung reviewed Sep 18, 2023
View reviewed changes
compiler/rustc_const_eval/src/transform/validate.rs
//! TypeChecker is meant to verify MIR types. It is used by the inliner to verify that type
//! instanciation do not mess things up (for instance #112332 and earlier instances).
//!
//! If a check depends on types, it should go in TypeChecker, otherwise it can go in CfgChecker.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You said it's "everything affected by substitution", not just types, right? E.g. if something depends on consts (which could be const generics) it also should go into TypeChecker?

@apiraino
Copy link
Contributor

think this is waiting on author to reply this comment

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2023
apiraino
apiraino reviewed Oct 19, 2023
View reviewed changes
compiler/rustc_const_eval/src/transform/validate.rs
//! statements and terminators...
//!
//! TypeChecker is meant to verify MIR types. It is used by the inliner to verify that type
//! instanciation do not mess things up (for instance #112332 and earlier instances).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//! instanciation do not mess things up (for instance #112332 and earlier instances).
//! instantiation do not mess things up (for instance #112332 and earlier instances).

typo?

@RalfJung
Copy link
Member

@cjgillot I think this just needs some minor wording changes?

@RalfJung
Copy link
Member

@cjgillot I recently noticed that both validators check retags. Is that kind of duplication of the checking logic expected behavior?

@bors
Copy link
Collaborator

bors commented May 24, 2024

☔ The latest upstream changes (presumably #125521) made this pull request unmergeable. Please resolve the merge conflicts.

@oskgo
Copy link
Contributor

oskgo commented Aug 18, 2024

Ping from triage:
@cjgillot Can you rebase and respond to the reviews? Thanks

@alex-semenyuk alex-semenyuk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 19, 2024
@JohnCSimon
Copy link
Member

@cjgillot
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you are going to continue please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive

@JohnCSimon JohnCSimon closed this Feb 5, 2025
@rustbot rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@apiraino apiraino apiraino left review comments

Assignees

@RalfJung RalfJung

Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjgillot @apiraino @RalfJung @bors @oskgo @JohnCSimon @alex-semenyuk @rustbot