-
Notifications
You must be signed in to change notification settings - Fork 13.3k
add codegen test for the move before passing to nocapture, by shared-ref arg #115050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add codegen test for the move before passing to nocapture, by shared-ref arg #115050
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
4b5a10b
to
effbfaa
Compare
r? @nikic |
How did you determine that this works with LLVM 16 already? |
@nikic Thank you! I'm sorry I misunderstood! llvm-16 can't work. |
remove trailing whitespace, add trailing newline fix llvm version and function name
effbfaa
to
d88c80f
Compare
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (9f48a85): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 629.54s -> 630.477s (0.15%) |
This PR adds codegen test for #107436 (comment) (It seems like this works from llvm-16?)
Fixes #107436