Skip to content

Implement From<&'a &'static str> for Arguments<'a> #114531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Implement From<&'a &'static str> for Arguments<'a> #114531

wants to merge 1 commit into from

Conversation

EFanZh
Copy link
Contributor

@EFanZh EFanZh commented Aug 6, 2023 •
edited
Loading

Provides a way to construct an Arguments object from an &'static str object, and calling as_str on the result object will return Some(&'static str).

ACP: rust-lang/lib-team#257.

@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2023

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 6, 2023
@EFanZh EFanZh mentioned this pull request Aug 6, 2023
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@EFanZh EFanZh force-pushed the implement-from-str-for-arguments branch from 99620b3 to 153c2e4 Compare August 6, 2023 10:09
@dtolnay dtolnay assigned dtolnay and unassigned joshtriplett Sep 16, 2023
dtolnay
dtolnay reviewed Sep 16, 2023
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Based on rust-lang/libs-team#257 (comment), I believe this is currently blocked while we work to figure out whether #115129 is going to be landable.

@dtolnay dtolnay added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2023
@dtolnay dtolnay assigned m-ou-se and unassigned dtolnay May 18, 2024
@bors
Copy link
Collaborator

bors commented Jul 29, 2024

☔ The latest upstream changes (presumably #125443) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC
Copy link
Member

The PR this was blocked on, is now closed due to inactivity, which should unblock this pr, so updating the labels

@Dylan-DPC Dylan-DPC added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jul 30, 2024
@dtolnay dtolnay added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. labels Jul 30, 2024
@m-ou-se m-ou-se added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2024
@alex-semenyuk
Copy link
Member

@EFanZh
From wg-triage. Any updates on this PR? Could you please resolve merge conflicts

@EFanZh
Copy link
Contributor Author

EFanZh commented Dec 29, 2024 •
edited
Loading

@alex-semenyuk: The original ACP suggests that we can add an Arguments::from_str method. I assume its intended signature is fn(&'static str) -> Arguments<'a>, but I don’t think it can be done without significant change to the underlying representation. Now I’ll draft this PR and see if I can come up with something later.

@EFanZh EFanZh marked this pull request as draft December 29, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay left review comments

Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@EFanZh @rustbot @rust-log-analyzer @bors @Dylan-DPC @alex-semenyuk @dtolnay @joshtriplett @m-ou-se