Rollup of 6 pull requests #113837
Merged
Rollup of 6 pull requests #113837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, treat placeholders equal to params
…-suggestion, r=oli-obk Fix removal span calculation of `unused_qualifications` suggestion Given a path such as `std::ops::Index<str>`, calculate the unnecessary qualification removal span by computing the beginning of the entire span until the ident span of the last path segment, which handles generic arguments and lifetime arguments in the last path segment. Previous logic only kept the ident span of the last path segment which is incorrect. Closes rust-lang#113808.
docs(release): Remove nightly-only cargo item See rust-lang/cargo#12343
…alias-display, r=notriddle Fix results search alias display Currently it's displayed like this:  With this fix:  r? `@notriddle`
a small `fn needs_drop` refactor I am generally a fan of exhaustively matching on `TyKind` once we care about more than 1 variant
…=oli-obk Ping spastorino on changes to SMIR r? `@oli-obk`
…compiler-errors Add `#[track_caller]` to lint related diagnostic functions This fixes locations reported by `-Ztrack-diagnostics`.
rustbot
added
A-meta
|
@bors r+ rollup=never p=6 |
bors
added
S-waiting-on-bors
This comment was marked as outdated.
This comment was marked as outdated.
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 8d361cbd91 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (42a982d): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 658.585s -> 660.475s (0.29%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
unused_qualificationssuggestion #113811 (Fix removal span calculation ofunused_qualificationssuggestion)fn needs_droprefactor #113824 (a smallfn needs_droprefactor)#[track_caller]to lint related diagnostic functions #113832 (Add#[track_caller]to lint related diagnostic functions)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup