Code

Update Clippy#113686

Code

Merged

bors merged 126 commits intorust-lang:masterrust-lang/rust:masterfrom

flip1995:clippyupflip1995/rust:clippyupCopy head branch name to clipboard

Jul 17, 2023

Commits

Commits on Jun 18, 2023

• new lint: `type_id_on_box`

  y21

  committed
  c5a9adc

  Copy full SHA for c5a9adc

• that was definitely not the right version

  y21

  committed
  9ab1e8e

  Copy full SHA for 9ab1e8e

• add it to the methods lint pass

  y21

  committed
  26ac76c

  Copy full SHA for 26ac76c

• add a few more test cases

  y21

  committed
  b0dfecd

  Copy full SHA for b0dfecd

Commits on Jun 20, 2023

• s/is_dyn_trait/is_dyn_any

  y21

  committed
  1b6738b

  Copy full SHA for 1b6738b

Commits on Jun 26, 2023

• Make simd_shuffle_indices use valtrees

  oli-obk

  committed
  7bd8ab7

  Copy full SHA for 7bd8ab7

• Add `SPEEDTEST`

  blyxyas

  committed
  d69c4f5

  Copy full SHA for d69c4f5

Commits on Jun 27, 2023

• Fix dogfood

  blyxyas

  committed
  0cd8bbc

  Copy full SHA for 0cd8bbc

Commits on Jun 28, 2023

• Finally fix dogfood

  blyxyas

  committed
  57923c3

  Copy full SHA for 57923c3

• Use depinfo to discover UI test dependencies

  Alexendoo

  committed
  4340a8a

  Copy full SHA for 4340a8a

Commits on Jun 30, 2023

• Don't lint manual_let_else in cases where the question mark operator would work

  Show description for 86391ab
  est31

  committed
  86391ab

  Copy full SHA for 86391ab

• Fix the now stricter lint in manual_rem_euclid.rs

  est31

  committed
  c6be621

  Copy full SHA for c6be621

• Put into one pass

  est31

  committed
  20dfaba

  Copy full SHA for 20dfaba

• Use `cargo build --tests` in CI

  Alexendoo

  committed
  2f7f139

  Copy full SHA for 2f7f139

Commits on Jul 1, 2023

• "try this" -> "try"

  smoelius

  committed
  420f3d1

  Copy full SHA for 420f3d1

Commits on Jul 2, 2023

• Auto merge of #112718 - oli-obk:SIMD-destructure_mir_const, r=cjgillot

  Show description for bb33e03
  bors

  committed
  bb33e03

  Copy full SHA for bb33e03

• Fix typos

  Centri3

  committed
  885a182

  Copy full SHA for 885a182

• Auto merge of #11058 - Centri3:typos, r=xFrednet

  Show description for 1990b72
  bors

  committed
  1990b72

  Copy full SHA for 1990b72

• Auto merge of #11053 - Alexendoo:ci-build-tests, r=flip1995

  Show description for 17a48c2
  bors

  committed
  17a48c2

  Copy full SHA for 17a48c2

• Merge commit '37f4c1725d3fd7e9c3ffd8783246bc5589debc53' into clippyup

  flip1995

  committed
  cb3ecf7

  Copy full SHA for cb3ecf7

• Fix valtree changes

  flip1995

  committed
  ba1ffec

  Copy full SHA for ba1ffec

• Fix compile-test tests to work with the new ui_test crate

  flip1995

  committed
  4aa4fec

  Copy full SHA for 4aa4fec

• let_and_return: lint 'static lifetimes, don't lint borrows in closures

  Alexendoo

  committed
  e29a5ac

  Copy full SHA for e29a5ac

• Auto merge of #11061 - Alexendoo:let-and-return-closures, r=llogiq

  Show description for 83d0682
  bors

  committed
  83d0682

  Copy full SHA for 83d0682

• Auto merge of #10920 - blyxyas:speedtest, r=llogiq

  Show description for ea4ca22
  bors

  committed
  ea4ca22

  Copy full SHA for ea4ca22

• [`missing_fields_in_debug`]: make sure `self` is an adt

  y21

  committed
  555ceb8

  Copy full SHA for 555ceb8

• Auto merge of #11069 - y21:issue11063, r=Alexendoo

  Show description for 4752466
  bors

  committed
  4752466

  Copy full SHA for 4752466

Commits on Jul 3, 2023

• Auto merge of #10987 - y21:type_id_on_box, r=llogiq

  Show description for c46ddeb
  bors

  committed
  c46ddeb

  Copy full SHA for c46ddeb

• Don't suppress manual_let_else if question_mark is allowed

  Show description for 6990eaa
  est31

  committed
  6990eaa

  Copy full SHA for 6990eaa

• Move pat_and_expr_can_be_question_mark into clippy_utils

  est31

  committed
  d80581c

  Copy full SHA for d80581c

• [`arc_with_non_send_sync`]: look for nested type parameters

  y21

  committed
  75c339c

  Copy full SHA for 75c339c

• Auto merge of #11077 - y21:issue11076, r=Manishearth

  Show description for 2b03bb0
  bors

  committed
  2b03bb0

  Copy full SHA for 2b03bb0

• Fix FP [`needless_raw_string_hashes`]

  Centri3

  committed
  9a58107

  Copy full SHA for 9a58107

• [`useless_vec`]: use the source span

  y21

  committed
  1f77f8c

  Copy full SHA for 1f77f8c

• Auto merge of #11081 - y21:issue11075, r=Manishearth

  Show description for a959061
  bors

  committed
  a959061

  Copy full SHA for a959061

• Auto merge of #10924 - est31:manual_let_else_question_mark, r=Centri3,flip1995,Manishearth

  Show description for 3f17c5c
  bors

  committed
  3f17c5c

  Copy full SHA for 3f17c5c

• Auto merge of #11078 - Centri3:11068, r=llogiq

  Show description for ba3bd8f
  bors

  committed
  ba3bd8f

  Copy full SHA for ba3bd8f

• [`useless_vec`]: add more tests for macro combinations

  y21

  committed
  b4549c5

  Copy full SHA for b4549c5

• Add needless_pass_by_ref lint

  GuillaumeGomez

  committed
  b41fc67

  Copy full SHA for b41fc67

• Add UI test for `needless_pass_by_ref_mut`

  GuillaumeGomez

  committed
  a43bea1

  Copy full SHA for a43bea1

• Update UI tests with new `needless_pass_by_ref_mut` lint

  GuillaumeGomez

  committed
  c62c7fa

  Copy full SHA for c62c7fa

• Fix warnings of `needless_pass_by_ref_mut` in clippy

  GuillaumeGomez

  committed
  dd3e00f

  Copy full SHA for dd3e00f

• Add warning for `NEEDLESS_PASS_BY_REF_MUT` lint about the fact that it changes API

  GuillaumeGomez

  committed
  33adfcd

  Copy full SHA for 33adfcd

• new lint: `read_line_without_trim`

  y21

  committed
  8fad54e

  Copy full SHA for 8fad54e

• add test cases for u32, f32, bool, String

  y21

  committed
  85f535b

  Copy full SHA for 85f535b

• Auto merge of #11094 - y21:issue11084, r=Alexendoo

  Show description for 3f4e599
  bors

  committed
  3f4e599

  Copy full SHA for 3f4e599

Commits on Jul 4, 2023

• Add warning about semver compatibility if it's a public function

  GuillaumeGomez

  committed
  f048f73

  Copy full SHA for f048f73

Commits on Jul 5, 2023

• Auto merge of #10970 - y21:read_line_without_trim, r=giraffate

  Show description for 1e656d8
  bors

  committed
  1e656d8

  Copy full SHA for 1e656d8

• Deal with fallout

  BoxyUwU

  committed
  4062418

  Copy full SHA for 4062418

• [`unnecessary_literal_unwrap`]: don't lint if binding initializer is expn

  y21

  committed
  6868c0a

  Copy full SHA for 6868c0a

• Patch clippy

  oli-obk

  committed
  a4f9914

  Copy full SHA for a4f9914

• Fix regex lints for regex 1.9.0

  Alexendoo

  committed
  f945351

  Copy full SHA for f945351

• Move `TyCtxt::mk_x` to `Ty::new_x` where applicable

  BoxyUwU

  committed
  cbe4682

  Copy full SHA for cbe4682

Commits on Jul 6, 2023

• Auto merge of #113291 - oli-obk:pretty_print_mir_const, r=RalfJung

  Show description for 8aca068
  bors

  committed
  8aca068

  Copy full SHA for 8aca068

• Auto merge of #113377 - BoxyUwU:move_ty_ctors_to_ty, r=compiler-errors

  Show description for 8c70e52
  bors

  committed
  8c70e52

  Copy full SHA for 8c70e52

• Auto merge of #11111 - Alexendoo:regex-def-paths, r=giraffate

  Show description for dd8e44c
  bors

  committed
  dd8e44c

  Copy full SHA for dd8e44c

Commits on Jul 7, 2023

• `manual_float_methods`

  Centri3

  committed
  f12edfd

  Copy full SHA for f12edfd

• Make suggestion give multiple alternatives

  Centri3

  committed
  5949f76

  Copy full SHA for 5949f76

• arc_with_non_send_sync: reword and move to suspicious

  Alexendoo

  committed
  4939a71

  Copy full SHA for 4939a71

• Auto merge of #11104 - Alexendoo:arc-with-non-send-sync, r=Centri3

  Show description for 26edd5a
  bors

  committed
  26edd5a

  Copy full SHA for 26edd5a

• Fix changelog PR listings, create them automatically in `fetch_prs_between.sh`

  Alexendoo

  committed
  2865526

  Copy full SHA for 2865526

• [`manual_range_patterns`]: lint negative values

  y21

  committed
  5cc0c04

  Copy full SHA for 5cc0c04

• [`manual_range_patterns`]: document what range we don't lint

  y21

  committed
  c927912

  Copy full SHA for c927912

• Rename `adjustment::PointerCast` and variants using it to `PointerCoercion`

  Show description for b5ac726
  Noratrieb

  committed
  b5ac726

  Copy full SHA for b5ac726

• Fix failing clippy tests

  Show description for 87373d7
  Alexendoo

  committed
  87373d7

  Copy full SHA for 87373d7

• Pass correct substs to `implements_trait` in `incorrect_impls`

  Show description for 5df1f66
  Noratrieb

  committed
  5df1f66

  Copy full SHA for 5df1f66

• Auto merge of #11122 - Nilstrieb:SUBSTITUTION-INITIATED, r=flip1995

  Show description for 2eff2f2
  bors

  committed
  2eff2f2

  Copy full SHA for 2eff2f2

• Auto merge of #11114 - Alexendoo:changelog-prs-fetch, r=xFrednet

  Show description for 3a1fc26
  bors

  committed
  3a1fc26

  Copy full SHA for 3a1fc26

Commits on Jul 8, 2023

• Auto merge of #113376 - Nilstrieb:pointer-coercions-are-not-casts-because-that-sounds-way-to-general-aaaa, r=oli-obk

  Show description for 1816caa
  bors

  committed
  1816caa

  Copy full SHA for 1816caa

• Delete `to_string_in_format_args_incremental.rs`

  Show description for 31d50a6
  Noratrieb

  committed
  31d50a6

  Copy full SHA for 31d50a6

• Auto merge of #113450 - Nilstrieb:src/bootstrap/test.rs, r=flip1995

  Show description for b485e4f
  bors

  committed
  b485e4f

  Copy full SHA for b485e4f

• implement `manual_partial_ord_impl`

  Show description for 2a1fd22
  Centri3

  committed
  2a1fd22

  Copy full SHA for 2a1fd22

• rename to `manual_partial_ord_and_ord_impl`

  Show description for 004e89d
  Centri3

  committed
  004e89d

  Copy full SHA for 004e89d

• use `other` instead of `self`

  Centri3

  committed
  844afbf

  Copy full SHA for 844afbf

• refactor

  Centri3

  committed
  a5dfb68

  Copy full SHA for a5dfb68

• Refactor, remove `Constant::to_bits`

  Centri3

  committed
  41438c2

  Copy full SHA for 41438c2

• Auto merge of #10788 - Centri3:duplicate_manual_partial_ord_impl, r=xFrednet,blyxyas

  Show description for e5db198
  bors

  committed
  e5db198

  Copy full SHA for e5db198

• Auto merge of #11049 - Centri3:manual_is_infinite, r=blyxyas,xFrednet

  Show description for 8e261c0
  bors

  committed
  8e261c0

  Copy full SHA for 8e261c0

• [significant_drop_tightening] Fix #11128

  c410-f3r

  committed
  2be695b

  Copy full SHA for 2be695b

• Dogfood

  c410-f3r

  committed
  6384221

  Copy full SHA for 6384221

• Auto merge of #11129 - c410-f3r:lock-1, r=Manishearth

  Show description for 6ae065f
  bors

  committed
  6ae065f

  Copy full SHA for 6ae065f

• Add test for #10535

  smoelius

  committed
  b4738a6

  Copy full SHA for b4738a6

• Fix #10535

  smoelius

  committed
  3bf2138

  Copy full SHA for 3bf2138

Commits on Jul 9, 2023

• Auto merge of #11130 - smoelius:fix-10535, r=Jarcho

  Show description for 757fe49
  bors

  committed
  757fe49

  Copy full SHA for 757fe49

• Auto merge of #10900 - GuillaumeGomez:needless-pass-by-ref, r=llogiq

  Show description for b46033e
  bors

  committed
  b46033e

  Copy full SHA for b46033e

• Auto merge of #11055 - smoelius:try-this, r=dswij

  Show description for ebd8d31
  bors

  committed
  ebd8d31

  Copy full SHA for ebd8d31

• Auto merge of #11110 - y21:unnecessary_literal_unwrap_ignore_expn, r=Jarcho

  Show description for 507d1c2
  bors

  committed
  507d1c2

  Copy full SHA for 507d1c2

Commits on Jul 10, 2023

• Auto merge of #11096 - y21:issue11091, r=giraffate

  Show description for 9058b04
  bors

  committed
  9058b04

  Copy full SHA for 9058b04

• changelog: Fix typo in `needless_pass_by_ref_mut` lint description

  GuillaumeGomez

  committed
  d1575d1

  Copy full SHA for d1575d1

• adjust applicability and suggest making binding mutable

  y21

  committed
  23ac723

  Copy full SHA for 23ac723

• Auto merge of #11133 - GuillaumeGomez:fix-description-typo, r=Manishearth

  Show description for 9ab7137
  bors

  committed
  9ab7137

  Copy full SHA for 9ab7137

• Auto merge of #11016 - y21:issue10029, r=blyxyas,dswij

  Show description for 3be3fb7
  bors

  committed
  3be3fb7

  Copy full SHA for 3be3fb7

• Drop uplifted `clippy::fn_null_check`

  Urgau

  committed
  103949b

  Copy full SHA for 103949b

Commits on Jul 11, 2023

• [`unnecessary_literal_unwrap`]: lint `unwrap_unchecked`

  y21

  committed
  cd1c853

  Copy full SHA for cd1c853

• [`unnecessary_literal_unwrap`]: also handle unwrap_err_unchecked

  y21

  committed
  0b5dac0

  Copy full SHA for 0b5dac0

• Auto merge of #111717 - Urgau:uplift_fn_null_check, r=oli-obk

  Show description for a8939e5
  bors

  committed
  a8939e5

  Copy full SHA for a8939e5

• Update version attribute for 1.71 lints

  xFrednet

  committed
  31397b4

  Copy full SHA for 31397b4

• Changelog for Rust 1.71 :crown:

  xFrednet

  committed
  5ea622c

  Copy full SHA for 5ea622c

Commits on Jul 12, 2023

• Changelog: Add disclaimer about the new format

  xFrednet

  committed
  7a3756a

  Copy full SHA for 7a3756a

• Ignore flaky clippy tests.

  ehuss

  committed
  660ef4f

  Copy full SHA for 660ef4f

• [`panic_in_result_fn`] remove `todo!`, `unimplemented!`, `unreachable!`

  Show description for c49c177
  panosfol

  committed
  c49c177

  Copy full SHA for c49c177

• Auto merge of #11045 - Alexendoo:extern-flags, r=flip1995

  Show description for 53d2938
  bors

  committed
  53d2938

  Copy full SHA for 53d2938

• Auto merge of #11098 - y21:issue11093, r=giraffate

  Show description for 3b43b1e
  bors

  committed
  3b43b1e

  Copy full SHA for 3b43b1e

• [`arithmetic_side_effect`]: allow different rhs type

  y21

  committed
  c5fc61c

  Copy full SHA for c5fc61c

• [`tuple_array_conversions`]: move from `complexity` to `nursery`

  Show description for 4102a30
  MingweiSamuel

  committed
  4102a30

  Copy full SHA for 4102a30

• Auto merge of #11138 - xFrednet:changelog-1-71, r=flip1995

  Show description for d398e59
  bors

  committed
  d398e59

  Copy full SHA for d398e59

• Auto merge of #11123 - panosfol:master, r=giraffate

  Show description for df92b52
  bors

  committed
  df92b52

  Copy full SHA for df92b52

Commits on Jul 13, 2023

• Add "Known problems" section to `needless_borrow` documentation

  smoelius

  committed
  050b714

  Copy full SHA for 050b714

• Auto merge of #11148 - smoelius:nb-known-problems, r=Jarcho

  Show description for b10a0aa
  bors

  committed
  b10a0aa

  Copy full SHA for b10a0aa

• Auto merge of #11146 - hydro-project:tuple-array-conversions, r=Centri3,xFrednet

  Show description for 631faa1
  bors

  committed
  631faa1

  Copy full SHA for 631faa1

• Auto merge of #11147 - y21:issue11145, r=Alexendoo

  Show description for a0e8257
  bors

  committed
  a0e8257

  Copy full SHA for a0e8257

• Add `imports_granularity = "Module"` to rustfmt.toml

  Alexendoo

  committed
  2811eff

  Copy full SHA for 2811eff

• Auto merge of #11095 - Alexendoo:rustfmt-imports, r=Manishearth

  Show description for 7ccf5d4
  bors

  committed
  7ccf5d4

  Copy full SHA for 7ccf5d4

• Set `unnecessary_cast` suggestion to `MaybeIncorrect` for pointer casts

  Show description for ea36a9d
  Alexendoo

  committed
  ea36a9d

  Copy full SHA for ea36a9d

• Trigger a rebuild when CLIPPY_CONF_DIR changes

  Alexendoo

  committed
  36279f1

  Copy full SHA for 36279f1

• Auto merge of #11154 - Alexendoo:track-clippy-conf-dir, r=flip1995

  Show description for 4b355d8
  bors

  committed
  4b355d8

  Copy full SHA for 4b355d8

Commits on Jul 14, 2023

• Auto merge of #11152 - Alexendoo:unnecessary-cast-applicability, r=Manishearth

  Show description for bafde54
  bors

  committed
  bafde54

  Copy full SHA for bafde54

• Merge remote-tracking branch 'upstream/master' into rustup

  flip1995

  committed
  415fdb2

  Copy full SHA for 415fdb2

• Bump Clippy version -> 0.1.73

  flip1995

  committed
  faa07d3

  Copy full SHA for faa07d3

• Bump nightly version -> 2023-07-14

  flip1995

  committed
  753c30f

  Copy full SHA for 753c30f

• Auto merge of #11157 - flip1995:rustup, r=flip1995

  Show description for 1d33469
  bors

  committed
  1d33469

  Copy full SHA for 1d33469

Commits on Jul 16, 2023

• don't hide lifetimes for `LateContext`

  y21

  committed
  498db80

  Copy full SHA for 498db80

• Auto merge of #11169 - y21:new_lint_unelide_lifetimes, r=xFrednet

  Show description for d9c24d1
  bors

  committed
  d9c24d1

  Copy full SHA for d9c24d1

Commits on Jul 17, 2023

• Merge commit 'd9c24d1b1ee61f276e550b967409c9f155eac4e3' into clippyup

  flip1995

  committed
  561303d

  Copy full SHA for 561303d

• Update Cargo.lock/toml

  Show description for c2490bd
  flip1995

  committed
  c2490bd

  Copy full SHA for c2490bd

• Another fix for incorrect_impls

  flip1995

  committed
  8ca13e8

  Copy full SHA for 8ca13e8