-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Emit an error when return-type-notation is used with type/const params #111047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @lcnr (rustbot has picked a reviewer for you, use r? to override) |
r? types |
☔ The latest upstream changes (presumably #111174) made this pull request unmergeable. Please resolve the merge conflicts. |
e5a61b7
to
0691c47
Compare
This comment has been minimized.
This comment has been minimized.
0691c47
to
d18b0ee
Compare
@jackh726 do you plan on reviewing this any time soon? otherwise, i'm gonna re-roll. |
☔ The latest upstream changes (presumably #111858) made this pull request unmergeable. Please resolve the merge conflicts. |
I'll do that (hoping it's fine) r? types |
@compiler-errors feel free to r=me after resolving conflicts. |
d18b0ee
to
b0eaaca
Compare
astconv is apparently too big, so i deleted a method that wasn't really necessary in b0eaaca |
@bors r=spastorino |
☀️ Test successful - checks-actions |
Finished benchmarking commit (e94bda3): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 647.017s -> 647.329s (0.05%) |
These are not intended to be supported initially, even though the compiler supports them internally...