Skip to content

update Miri #101248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2022
Merged

update Miri #101248

merged 1 commit into from
Sep 2, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Aug 31, 2022

r? @ghost
Fixes #101067

@rustbot
Copy link
Collaborator

rustbot commented Aug 31, 2022

The Miri submodule was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

RalfJung commented Aug 31, 2022

tidy error: invalid license CC0-1.0 in abort_on_panic 2.0.0 (registry+https://github.com/rust-lang/crates.io-index)

Hm... supposedly CC0 waives copyright and thus should imply the MIT+Apache that we need?

@rust-log-analyzer

This comment has been minimized.

@RalfJung
Copy link
Member Author

License discussion continuing on Zulip; the short version is: it's complicated.

@RalfJung
Copy link
Member Author

RalfJung commented Sep 1, 2022

The dependency in question got removed from Miri.
@bors r= p=1

@bors
Copy link
Collaborator

bors commented Sep 1, 2022

📌 Commit f76eac4 has been approved by ``

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 1, 2022
@RalfJung
Copy link
Member Author

RalfJung commented Sep 1, 2022

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Sep 1, 2022

📌 Commit f76eac4 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 2, 2022

⌛ Testing commit f76eac4 with merge e4f0493...

@bors
Copy link
Collaborator

bors commented Sep 2, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing e4f0493 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 2, 2022
@bors bors merged commit e4f0493 into rust-lang:master Sep 2, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 2, 2022
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #101248!

Tested on commit e4f0493.
Direct link to PR: #101248

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Sep 2, 2022
Tested on commit rust-lang/rust@e4f0493.
Direct link to PR: <rust-lang/rust#101248>

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e4f0493): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
5.9% [3.2%, 8.7%] 2
Improvements ✅
(primary)
-2.8% [-2.8%, -2.8%] 1
Improvements ✅
(secondary)
-3.2% [-4.3%, -2.0%] 2
All ❌✅ (primary) -2.8% [-2.8%, -2.8%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.3% [-2.3%, -2.3%] 1
All ❌✅ (primary) - - 0

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

@RalfJung RalfJung deleted the miri branch September 2, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#100043
6 participants