-
Notifications
You must be signed in to change notification settings - Fork 189
Move some chapters to the rustc-guide #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mark-i-m Thank you for your PR, to accept this PR we'd also need to add redirects to the rustc-guide. You can add the appropriate redirects in the code shown below. https://github.com/rust-lang/rust-forge/blob/master/blacksmith/src/lib.rs#L116 |
@XAMPPRocky Thanks! Done :) |
@mark-i-m I left one last code review comment, and also in this PR could you remove |
@XAMPPRocky I attempted to do the requested modifications, but I had a hard time figuring out how to run the blacksmith tool, so let me know if I did something incorrect. |
@mark-i-m CI failed: https://travis-ci.com/rust-lang/rust-forge/builds/140145315#L470-L472 To run the tool calling |
@mark-i-m As pietro said you should just need to run |
Co-Authored-By: XAMPPRocky <[email protected]>
Thanks! It looks like CI is passing now. I also added a note to the README. I'm still unable to run locally, apparently because my installed mdbook is too recent, which is interesting... |
@mark-i-m Thank you again for your PR! |
r? @pietroalbini
cc rust-lang/rustc-dev-guide#535