-
Notifications
You must be signed in to change notification settings - Fork 1.6k
add cast-nan-to-int
lint
#9617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cast-nan-to-int
lint
#9617
Conversation
d17e7fa
to
5928b61
Compare
I've added the note you suggested. Anything else needed? |
☔ The latest upstream changes (presumably #9572) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing else, looks good!
you can r=me it with the conflict resolved
5928b61
to
e4c80f2
Compare
Thank you for the review! |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This fixes #371.
r? @Alexendoo
changelog: add [
cast-nan-to-int
] lint