Rewrite update-all-references bash scripts in Rust #6413
Conversation
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
#5394 also mentions that |
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
This won't work in rustc I guess. But we can make this work in a later PR somehow.
clippy_dev/src/bless.rs
Outdated
| } | ||
| } | ||
|
|
||
| fn update_test_file(test_file_path: PathBuf) { |
There was a problem hiding this comment.
NIT: Maybe a better naming would be
| fn update_test_file(test_file_path: PathBuf) { | |
| fn update_test_file(reference_file_path: PathBuf) { |
and the same for other *_test_file* names.
And then for build_output, test_output instead?
With this the if clause below would become if test_output != reference_file, which is more intuitive to me.
There was a problem hiding this comment.
I agree that's much better, thanks!
phansch
added
S-waiting-on-author
This replaces the `update-all-references` scripts with a single
cargo dev bless
command.
cc rust-lang#5394
|
@bors r=flip1995 |
|
📌 Commit b8501e1 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
5 participants
This replaces the
update-all-referencesscripts with a singlecommand. It should behave mostly the same as the bash scripts. The major difference is, that it can be called from the project root and will always update the files in all of the test suites.
cc #5394
changelog: none