Rewrite update-all-references bash scripts in Rust #6413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
#5394 also mentions that |
matthiaskrgr
reviewed
Dec 3, 2020
flip1995
reviewed
Dec 6, 2020
clippy_dev/src/bless.rs
Outdated
| } | ||
| } | ||
|
|
||
| fn update_test_file(test_file_path: PathBuf) { |
There was a problem hiding this comment.
NIT: Maybe a better naming would be
Suggested change
| fn update_test_file(test_file_path: PathBuf) { | |
| fn update_test_file(reference_file_path: PathBuf) { |
and the same for other *_test_file* names.
And then for build_output, test_output instead?
With this the if clause below would become if test_output != reference_file, which is more intuitive to me.
There was a problem hiding this comment.
I agree that's much better, thanks!
phansch
added
S-waiting-on-author
This replaces the `update-all-references` scripts with a single
cargo dev bless
command.
cc rust-lang#5394
|
@bors r=flip1995 |
|
📌 Commit b8501e1 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
update-all-referencesscripts with a singlecommand. It should behave mostly the same as the bash scripts. The major difference is, that it can be called from the project root and will always update the files in all of the test suites.
cc #5394
changelog: none