Fix cargo dev new_lint for late lint passes

[ebroto]

Since 30c046e, LateLintPass has only one lifetime parameter.

I'm not sure how to easily test this, I think adding this kind of tests would be probably part of #5394

changelog: none

[rust-highfive]

r? @matthiaskrgr

(rust_highfive has picked a reviewer for you, use r? to override)

[matthiaskrgr]

I'm not sure how to easily test this

We could just run

cargo dev new_lint  --name new_early_pass --pass early
cargo dev new_lint  --name new_late_pass --pass late
cargo check

somewhere in our CI pipeline I guess?

[ebroto]

Oh good point, I'll look into that.

I'm not familiar enough with the pipeline, but I guess that there should also be some cleanup in case more commits are pushed and the workspace is reused.

[matthiaskrgr]

I think this can be added here https://github.com/rust-lang/rust-clippy/blob/master/.github/workflows/clippy.yml#L94

Something like that may do:

    - name: cargo-dev new early lint test 
      run: cargo dev new_lint --name new_early_pass --pass early

    - name: cargo-dev new late lint test 
      run: cargo dev new_lint --name new_late_pass --pass late

    - name: cargo-dev build check
      run: cargo check

    - name: revert cargo-dev changes
      run: git reset --hard HEAD

[ebroto]

Will try this tomorrow ASAP :), thanks!

[ebroto]

Testing the failure case...

[ebroto]

Testing the success case...

(Hmm I should have left the previous commit showing the failure for review)

[ebroto]

@matthiaskrgr I think it should be ready to review now :)

[matthiaskrgr]

Looks good, thanks!

[matthiaskrgr]

@bors r+

[bors]

📌 Commit 6dd65b8 has been approved by matthiaskrgr

[bors]

⌛ Testing commit 6dd65b8 with merge 2d86cc5...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: matthiaskrgr
Pushing 2d86cc5 to master...