Skip to content

fix for latest nightly #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2015
Merged

fix for latest nightly #474

merged 1 commit into from
Nov 30, 2015

Conversation

hobofan
Copy link
Contributor

@hobofan hobofan commented Nov 27, 2015

Fixes breakage introduced by rust-lang/rust#30043

Fixes breakage introduced by rust-lang/rust#30043
@hobofan
Copy link
Contributor Author

hobofan commented Nov 27, 2015

Blocked by rust-lang/regex#135

@llogiq
Copy link
Contributor

llogiq commented Nov 27, 2015

Thanks! 👍 We'll merge when nightly catches up 😄

@llogiq
Copy link
Contributor

llogiq commented Nov 27, 2015

Seems to have hit. r+, but regex_macros doesn't yet have it.

@mrmonday
Copy link
Contributor

When this is merged, could you make sure to bump the crate version number too?

I keep having to poke @Manishearth to update it on IRC each time clippy breaks on nightly.

@llogiq
Copy link
Contributor

llogiq commented Nov 28, 2015

OK, I'll try – whether I succeed depends on me being awake when it lands. 😄

@Manishearth
Copy link
Member

I'll remember, don't worry.

@Manishearth Manishearth merged commit 7d583da into rust-lang:master Nov 30, 2015
@Manishearth
Copy link
Member

Merging this, since everything else passes and it's been a few days since I opened the regex PR (and folks are complaining about broken clippy).

Also, published a new clippy

@llogiq
Copy link
Contributor

llogiq commented Nov 30, 2015

Ok, but tests will fail then. Perhaps we should find another way to test our external macro check that doesn't require regex?

@Manishearth
Copy link
Member

Ok with disabling the macro test temporarily.

@Manishearth
Copy link
Member

We could write some convoluted macro tests I guess.

@llogiq
Copy link
Contributor

llogiq commented Nov 30, 2015

That will only work if we put it in its own crate (which was the point of using regex in the test in the first place).

@Manishearth
Copy link
Member

We can provide auxiliary files for compiletest. not sure if that works out of tree.

Or use a path dep to a local crate

@llogiq
Copy link
Contributor

llogiq commented Nov 30, 2015

Yeah, that would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants