-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix for latest nightly #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes breakage introduced by rust-lang/rust#30043
Blocked by rust-lang/regex#135 |
Thanks! 👍 We'll merge when nightly catches up 😄 |
Seems to have hit. r+, but regex_macros doesn't yet have it. |
When this is merged, could you make sure to bump the crate version number too? I keep having to poke @Manishearth to update it on IRC each time clippy breaks on nightly. |
OK, I'll try – whether I succeed depends on me being awake when it lands. 😄 |
I'll remember, don't worry. |
Merging this, since everything else passes and it's been a few days since I opened the regex PR (and folks are complaining about broken clippy). Also, published a new clippy |
Ok, but tests will fail then. Perhaps we should find another way to test our external macro check that doesn't require regex? |
Ok with disabling the macro test temporarily. |
We could write some convoluted macro tests I guess. |
That will only work if we put it in its own crate (which was the point of using regex in the test in the first place). |
We can provide auxiliary files for compiletest. not sure if that works out of tree. Or use a path dep to a local crate |
Yeah, that would work. |
Fixes breakage introduced by rust-lang/rust#30043