Skip to content

Fix ImplItems being ignored #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 5, 2018
Merged

Fix ImplItems being ignored #2415

merged 3 commits into from
Feb 5, 2018

Conversation

HMPerson1
Copy link
Contributor

Fixes #2356

Apparently NodeImplItem is distinct from NodeItem, but we want both.

@oli-obk
Copy link
Contributor

oli-obk commented Jan 31, 2018

Makes sense.

Can you add the test from the issue as a regression test?

@HMPerson1
Copy link
Contributor Author

Should it be in while_loop.rs with the other tests for while_let_on_iterator? Or is there a better place for testing utility functions?

@oli-obk
Copy link
Contributor

oli-obk commented Feb 1, 2018

Nah, just throw in the example from the issue. Put it in a separate file though.

@HMPerson1 HMPerson1 changed the title Fix get_enclosing_block Fix ImplItems being ignored Feb 2, 2018
@HMPerson1
Copy link
Contributor Author

I found some other cases where ImplItems were forgotten about. Might as well fix those too.

@oli-obk oli-obk merged commit 7fddc61 into rust-lang:master Feb 5, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Feb 5, 2018

Great fixes!

@HMPerson1 HMPerson1 deleted the fix-2356 branch February 6, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HMPerson1 @oli-obk