Implement cargo clippy --all
#1975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements workspace support for `cargo clippy` by running clippy over all packages in the workspace (in serial). This should probably be parallelised in future (as `cargo build --all`).
|
And this fails to compile due to #1970... |
oli-obk
reviewed
Aug 21, 2017
.travis.yml
Outdated
| @@ -28,7 +28,7 @@ script: | |||
| - cargo test --features debugging | |||
| - mkdir -p ~/rust/cargo/bin | |||
| - cp target/debug/cargo-clippy ~/rust/cargo/bin/cargo-clippy | |||
| - PATH=$PATH:~/rust/cargo/bin cargo clippy -- -D clippy | |||
| - PATH=$PATH:~/rust/cargo/bin cargo clippy --all -- -D clippy | |||
There was a problem hiding this comment.
I think this means we can remove the line below?
|
Thanks! |
bjgill
added a commit
to bjgill/rust-clippy
that referenced
this pull request
Aug 22, 2017
Should have added this as part of rust-lang#1975
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements workspace support for
cargo clippyby running clippyover all packages in the workspace (in serial).
This should probably be parallelised in future (as
cargo build --all).See #1707