Add a note for disallowed items referring to the config file #14663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* More precise spans in diagnostics * Allow multiple diagnostics for each config value * Ability to capture spans in the parsed config * Easier support of `..` in lists * Remove `clippy_utils` dependancy from `clippy_config` * Multi-column support for long suggestion lists
rustbot
added
the
S-waiting-on-review
Jarcho
changed the title
|
☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #13084
The
disallow_span_linttest is removed since it depends on aclippy.tomlfrom outside the test directory. This causesui_testto be unable to normalize the path (see ci failure).changelog: [disallowed_*][await_holding_invalid]: Note the config span the first time an invalid item is used.