Skip to content

match_same_arms, ifs_same_cond: lint once per same arm/condition #14637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

match_same_arms, ifs_same_cond: lint once per same arm/condition #14637

wants to merge 1 commit into from

Conversation

Alexendoo
Copy link
Member

A large fraction of the lints emitted in CI lintcheck come from this match, currently for n same arms ((n - 1) * n)/2 lints are emitted, with this change it will be emitted as a single lint

Also fixes #13835

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 16, 2025
@Alexendoo
Copy link
Member Author

110 added, 268700 removed, 172 changed

😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@llogiq llogiq

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing @rust-nofix from match_same_arms requires lint fixes
3 participants
@Alexendoo @rustbot @llogiq