Skip to content

item_name_repetitions: exclude enum variants with identical path components #14619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

item_name_repetitions: exclude enum variants with identical path components #14619

wants to merge 1 commit into from
+52 −3

Conversation

aaron-ang
Copy link
Contributor

@aaron-ang aaron-ang commented Apr 15, 2025 •
edited
Loading

fix #13637

As suggested in the PR above, we should not lint enum variants containing matching path names.

changelog: [item_name_repetitions]: exclude enum variants with identical path components

@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 15, 2025
@aaron-ang
Copy link
Contributor Author

r? @samueltardieu

@rustbot
Copy link
Collaborator

rustbot commented Apr 22, 2025

samueltardieu is on vacation.

Please choose another assignee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@llogiq llogiq

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enum_variant_names does not consider encapsulated type
3 participants
@aaron-ang @rustbot @llogiq