Implement 'Re-implementing PartialEq::ne' lint
#1307
Conversation
| PARTIALEQ_NE_IMPL, | ||
| impl_item.span, | ||
| "Re-implementing `PartialEq::ne`") | ||
| } |
There was a problem hiding this comment.
This should also give a help message telling the user what to do( remove the impl)
There was a problem hiding this comment.
Any suggestion for wording? Maybe just appending ... is unnecessary?
| @@ -1,5 +1,5 @@ | |||
| #!/bin/sh | |||
| rm -rf target*/*so | |||
| cargo build --lib && cp -R target target_recur && cargo rustc -- -Zextra-plugins=clippy -Ltarget_recur/debug -Dclippy_pedantic -Dclippy || exit 1 | |||
| cargo build --lib && cp -R target target_recur && cargo rustc --lib -- -Zextra-plugins=clippy -Ltarget_recur/debug -Dclippy_pedantic -Dclippy || exit 1 | |||
There was a problem hiding this comment.
Huh, how did this ever work?
There was a problem hiding this comment.
Oh.... This is dogfood.sh, nevermind.
There was a problem hiding this comment.
Yeah, seems like nobody's run this ever since cargo-clippy appeared 😄 .
There was a problem hiding this comment.
Cargo test will actually run a separate implementation of dogfood, so there wasn't any need for that script as far as I knew
| MetaItemKind::Word(ref word) => word == "clippy_dump", | ||
| _ => false, | ||
| }) | ||
| attr::contains_name(attrs, "clippy_dump") |
There was a problem hiding this comment.
Neat cleanup, didn't know about this function
|
The other PR conflicted with this one. You need to rebase/merge and rerun util/update_lints.sh |
There was a problem hiding this comment.
Clippy_dump is around a week old ;) but you're right, it should get documented. Did it help you at all in this case?
Oh right, I tried it on the impl and got the helpful output
item ``
visibility inherited from outer item
error: internal compiler error: ../src/librustc/hir/map/mod.rs:356: local_def_id: no entry for `9`, which has a map of `Some(NotPresent)`
:D . I've added a commit to fix the error.
| PARTIALEQ_NE_IMPL, | ||
| impl_item.span, | ||
| "Re-implementing `PartialEq::ne`") | ||
| } |
There was a problem hiding this comment.
Any suggestion for wording? Maybe just appending ... is unnecessary?
| @@ -1,5 +1,5 @@ | |||
| #!/bin/sh | |||
| rm -rf target*/*so | |||
| cargo build --lib && cp -R target target_recur && cargo rustc -- -Zextra-plugins=clippy -Ltarget_recur/debug -Dclippy_pedantic -Dclippy || exit 1 | |||
| cargo build --lib && cp -R target target_recur && cargo rustc --lib -- -Zextra-plugins=clippy -Ltarget_recur/debug -Dclippy_pedantic -Dclippy || exit 1 | |||
There was a problem hiding this comment.
Yeah, seems like nobody's run this ever since cargo-clippy appeared 😄 .
Sgtm |
Ok, changed and squashed. |
|
Travis says you forgot to run util/update_lints.py |
|
Fixed |
|
Thanks! Great lint and nice cleanups |
Closes #86
@oli-obk I didn't track the time for implementing this, but most of it was probably spent on figuring out why
compiletestkept saying0 unexpected errors found, 1 expected errors not found. In the end, I copied and ran therustccmdline for that file separately, which showed that there was indeed an unexpected and very simple error:main function not found:| . Apparentlycompiletestmay swallow unexpected errors.So perhaps
CONTRIBUTING.mdshould include some hints for debugging lints, including mentioning theTESTNAMEenv var and#[clippy_dump].