-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Rename thread_local_initializer_can_be_made_const to missing_const_for_thread_local #12974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename thread_local_initializer_can_be_made_const to missing_const_for_thread_local #12974
Conversation
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
e10ebef
to
333c887
Compare
^^ @Alexendoo |
How about |
4a097af
to
72a8a12
Compare
☔ The latest upstream changes (presumably #13037) made this pull request unmergeable. Please resolve the merge conflicts. |
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands:
The following commits are merge commits: |
3c06e6e
to
b62576f
Compare
facf982
to
fe04ab3
Compare
@Alexendoo sounds good, renamed |
fe04ab3
to
44cf7cb
Compare
44cf7cb
to
6621e6c
Compare
Great, thanks! @bors r+ |
…can_be_made_const, r=Alexendoo Rename thread_local_initializer_can_be_made_const to missing_const_for_thread_local Close #12934 As discussed at #12934 name `thread_local_initializer_can_be_made_const` sounds against convention for other lints which describe the issue/wrong code but not suggestion and it is quite long. The new name take example from existing lint `missing_const_for_fn` changelog [`thread_local_initializer_can_be_made_const`] : Rename to `missing_const_for_thread_local`
💔 Test failed - checks-action_test |
@bors retry |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Close #12934
As discussed at #12934 name
thread_local_initializer_can_be_made_const
sounds against convention for other lints which describe the issue/wrong code but not suggestion and it is quite long. The new name take example from existing lintmissing_const_for_fn
changelog:
thread_local_initializer_can_be_made_const
: Rename to [missing_const_for_thread_local
]