Skip to content

Conversation

B14CK313
Copy link
Contributor

This is a followup to #12804, fixing a similar issue for derive_partial_eq_without_eq by using span_lint_hir_and_then instead of span_lint_and_sugg.

Additionally tests for both #[allow(clippy::derive_partial_eq_without_eq)] and #[expect(clippy::derive_partial_eq_without_eq)] are added.

changelog:[derive_partial_eq_without_eq]: fulfill expectations

changelog: fulfill expectations in [derive_partial_eq_without_eq]
@rustbot
Copy link
Collaborator

rustbot commented May 24, 2024

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 24, 2024
@B14CK313
Copy link
Contributor Author

Please review line clippy_lints/src/derive.rs:459 especially, there might be a better way to do this that I don't know of.

@y21
Copy link
Member

y21 commented May 24, 2024

Looks all good to me. That line also looks fine. Thank you for picking this up! :D

@bors r+

@bors
Copy link
Contributor

bors commented May 24, 2024

📌 Commit 7f30b20 has been approved by y21

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 24, 2024

⌛ Testing commit 7f30b20 with merge f16317e...

@bors
Copy link
Contributor

bors commented May 24, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing f16317e to master...

@bors bors merged commit f16317e into rust-lang:master May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants